[next] Make app route prerender filter dynamic route specific (#11863)

ijjk · web-flow · commit a95c4c43a660 · 2024-07-16T17:01:58.000-07:00
Follow-up to #11862 ensuring we only filter for dynamic app routes as those are the only ones we were concerned about specifically and the related test change shouldn't have been necessary.
diff --git a/.changeset/warm-carrots-scream.md b/.changeset/warm-carrots-scream.md
@@ -0,0 +1,5 @@
+---
+'@vercel/next': patch
+---
+
+Make app route prerender filter dynamic route specific
diff --git a/packages/next/src/server-build.ts b/packages/next/src/server-build.ts
@@ -1403,14 +1403,20 @@ export async function serverBuild({
 
   prerenderRoutes.forEach(route => {
     if (experimentalPPRRoutes.has(route)) return;
-    // we can't delete app route lambdas just because
-    // they are in the prerender manifest since a dynamic
-    // route can have some prerendered paths and the rest SSR
-    if (inversedAppPathManifest?.[route]) return;
     if (routesManifest?.i18n) {
       route = normalizeLocalePath(route, routesManifest.i18n.locales).pathname;
     }
 
+    if (
+      // we can't delete dynamic app route lambdas just because
+      // they are in the prerender manifest since a dynamic
+      // route can have some prerendered paths and the rest SSR
+      inversedAppPathManifest[route] &&
+      isDynamicRoute(route)
+    ) {
+      return;
+    }
+
     delete lambdas[
       normalizeIndexOutput(
         path.posix.join('./', entryDirectory, route === '/' ? '/index' : route),
diff --git a/packages/next/test/integration/integration-1.test.js b/packages/next/test/integration/integration-1.test.js
@@ -88,7 +88,7 @@ if (parseInt(process.versions.node.split('.')[0], 10) >= 16) {
       )
     ).toBeFalsy();
 
-    expect(lambdas.size).toBe(7);
+    expect(lambdas.size).toBe(6);
 
     // RSC, root-level page.js
     expect(buildResult.output['index']).toBeDefined();

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@vercel/next': patch
 +---
++
 +Make app route prerender filter dynamic route specific
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ if (parseInt(process.versions.node.split('.')[0], 10) >= 16) {`
`88`	`88`	`)`
`89`	`89`	`).toBeFalsy();`
`90`	`90`
`91`		`- expect(lambdas.size).toBe(7);`
	`91`	`+ expect(lambdas.size).toBe(6);`
`92`	`92`
`93`	`93`	`// RSC, root-level page.js`
`94`	`94`	`expect(buildResult.output['index']).toBeDefined();`