Skip to content

Commit 3385dda

Browse files
authored
Merge branch 'main' into python/supportsresponsestreaming
2 parents 9acd9bb + 4088283 commit 3385dda

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

.changeset/gold-months-live.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"vercel": patch
3+
---
4+
5+
[cli] update warning in ls --update-required for clarity

packages/cli/src/commands/project/list.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,23 @@ export default async function list(
8080
const upcomingDeprecationVersionsList = [];
8181

8282
for (const nodeVersion of NODE_VERSIONS) {
83-
if (
83+
// This logic presumes that adding a discontinue date for a node version
84+
// implies that the version is deprecated.
85+
// If there are scenarios where we will be deprecating a version
86+
// without knowing the discontinue date
87+
// Then we'll want to consider adding a `deprecationDate` field to the nodeVersion type
88+
const upcomingDiscontinueDate =
8489
nodeVersion.discontinueDate &&
85-
nodeVersion.discontinueDate.valueOf() > Date.now()
86-
) {
90+
nodeVersion.discontinueDate.valueOf() > Date.now();
91+
if (upcomingDiscontinueDate) {
8792
upcomingDeprecationVersionsList.push(nodeVersion.range);
8893
}
8994
}
9095

9196
output.warn(
92-
`The following Node.js versions will be deprecated soon: ${upcomingDeprecationVersionsList.join(
97+
`The following Node.js versions are deprecated: ${upcomingDeprecationVersionsList.join(
9398
', '
94-
)}. Please upgrade your projects immediately.`
99+
)} and will be discontinued soon. Please upgrade your projects immediately.`
95100
);
96101
output.log(
97102
'For more information visit: https://vercel.com/docs/functions/serverless-functions/runtimes/node-js#node.js-version'

0 commit comments

Comments
 (0)