add user level tracing#6701
Merged
Merged
Conversation
ghost
added
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
Contributor
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Contributor
|
✅ This change can build |
Contributor
🟢 CI successful 🟢Thanks |
Contributor
Linux Benchmark for 1d11795Click to view benchmark
|
ForsakenHarmony
approved these changes
Dec 5, 2023
Comment on lines
+39
to
+40
| let _entered = current_span.entered(); | ||
| let _entered = span.entered(); |
Contributor
There was a problem hiding this comment.
why are we entering 2 spans here?
Member
Author
There was a problem hiding this comment.
The span might be disabled, in that case we at least want to keep the current span
| Ok(Vc::cell(assets)) | ||
| Ok(Vc::cell(assets)) | ||
| } | ||
| .instrument(span) |
Contributor
There was a problem hiding this comment.
can't we "just" enter the span here?
Member
Author
There was a problem hiding this comment.
For async methods one need to use instrument to "enter" the span on every poll.
EnteredSpan is not Send
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Dec 5, 2023
* vercel/turborepo#6588 <!-- Leah - ci: remove daily turbopack next.js integration test workflow --> * vercel/turborepo#6666 <!-- Will Binns-Smith - Turbopack css: treat `composes` and `@import` as urls when resolving --> * vercel/turborepo#6701 <!-- Tobias Koppers - add user level tracing --> * vercel/turborepo#6616 <!-- Leah - feat(turbopack): support "loading" WebAssembly injected as global varables in edge runtime --> Closes PACK-2086
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Add a few user-focused info level spans that can be used to trace a normal build Closes PACK-2082
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Add a few user-focused info level spans that can be used to trace a normal build Closes PACK-2082
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Add a few user-focused info level spans that can be used to trace a normal build Closes PACK-2082
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Add a few user-focused info level spans that can be used to trace a normal build Closes PACK-2082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a few user-focused info level spans that can be used to trace a normal build
Closes PACK-2082