Using posix path resolution. Resolves serve issue #525 - #89
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 324 324
=====================================
Hits 324 324
Continue to review full report at Codecov.
|
This was referenced Jun 6, 2019
Matt-J-Hosking
approved these changes
Jun 8, 2019
|
I approve! :) Please get this one in. |
leo
approved these changes
Jun 19, 2019
leo
left a comment
leo
left a comment
Contributor
There was a problem hiding this comment.
The tests are green. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves vercel/serve#525
path.resolve('/some-url')returnsC:\\some-urlin Windows. Which breaks rewrites and makes the serve--singleoption not work in windows.Using path.posix gives us linux/unix/posix functionality for resolving the path, which preserves the security fix that was added in #76 while still working in Windows.
I have verified that the
--singleoption works with my changes, in both Windows 10 and Mac.