feat: replace the 'fast-url-parser' module with the 'node:url' module#207
feat: replace the 'fast-url-parser' module with the 'node:url' module#207AndyBitz merged 1 commit intovercel:mainfrom
Conversation
|
@gweesin You probably already know this but I think @leo was previously merging on this repo but has left Vercel (if his twitter is any indication). Not so sure this is getting merged unless someone else from over there has the ability to approve. Maybe @rauchg or @TooTallNate knows who hits the buttons on this repo now? |
|
I indeed don't have access to this repo anymore, but I just pressed "View git blame" on the line that imports I was wondering why (I don't remember the reason), but looking at the readme of the fast-url-parser package and considering it has 4 million weekly downloads, it seems that the only reason why the package exists is to make the native So unless the native But agreed that, if the owner of |
|
I've run
For your information, here is the benchmark displayed in
|
|
That seems like a reasonable tradeoff to me, considering that using the native module would also make the package lighter. Great to see that Node has gotten a lot faster. I'll try to ping someone at Vercel to merge this PR. |
|
Thank you all for hopping on this. Really appreciate it. |
closed #204