This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Fix warnings when packaging with leveldown.#1273
Closed
tegefaulkes wants to merge 1 commit intovercel:mainfrom
Closed
Fix warnings when packaging with leveldown.#1273tegefaulkes wants to merge 1 commit intovercel:mainfrom
tegefaulkes wants to merge 1 commit intovercel:mainfrom
Conversation
Removes dictionary override for bundling leveldown. changes from PR vercel#837 makes this unnecessary now.
9 tasks
12 tasks
|
This is pretty quick fix. Can it be merged soon? |
|
Resolvable in local config, e.g. package.json in the thing you're packaging up: This essentially removes the patch specified in |
Contributor
|
This can be handeld now using |
Merged
16 tasks
|
What is the |
|
@robertsLando Changing to use We're using something like: |
|
It required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1264.
Relates to #837
The goal of this PR is to remove warnings when packaging a project that includes the leveldown native module.
This change should;