This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Prerequisite changes of feature/compression#1204
Merged
Conversation
jesec
force-pushed
the
pr/compression-splitted
branch
from
fc56bb4 to
c66f229
Compare
erossignon
suggested changes
Jun 2, 2021
jesec
force-pushed
the
pr/compression-splitted
branch
from
c66f229 to
47047a7
Compare
erossignon
suggested changes
Jun 3, 2021
Contributor
erossignon
left a comment
erossignon
left a comment
There was a problem hiding this comment.
I see a few 'var' left in boostrap.js that we could get rid off while we are here.
May be we could replace path_ with either filename pathname or foldername as appropriate.
jesec
force-pushed
the
pr/compression-splitted
branch
from
47047a7 to
ba41884
Compare
Contributor
Author
Done. I think |
robertsLando
approved these changes
Jun 3, 2021
erossignon
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compression change (#1200) is giant. It would be easier for us to split, review and merge the related changes first.