Skip to content

fix: add playwright-core support#213

Merged
styfle merged 1 commit into
vercel:mainfrom
mxschmitt:bugfix/playwright-core
May 23, 2021
Merged

fix: add playwright-core support#213
styfle merged 1 commit into
vercel:mainfrom
mxschmitt:bugfix/playwright-core

Conversation

@mxschmitt

Copy link
Copy Markdown
Contributor

Verified that the test was failing without the special case and it's passing with the special case.

Closes #184
Closes #211

Relates microsoft/playwright#5862

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle enabled auto-merge (squash) May 23, 2021 23:39
@codecov

codecov Bot commented May 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #213 (5c895c8) into main (96c265d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   80.17%   80.19%   +0.02%     
==========================================
  Files          13       13              
  Lines        1402     1404       +2     
  Branches      537      538       +1     
==========================================
+ Hits         1124     1126       +2     
  Misses        109      109              
  Partials      169      169              
Impacted Files Coverage Δ
src/utils/special-cases.ts 88.75% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c265d...5c895c8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot deploy Playwright to Vercel - required file not traced by NFT

2 participants