Turbopack: lazy require metadata and handle TLA#91705
Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Collaborator
Tests Passed |
Merging this PR will degrade performance by 3.44%
Performance Changes
Comparing 
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
| self.loader_tree_code, | ||
| "{s} url: fillMetadataSegment({}, await props.params, {}, true) + \ | ||
| `?${{{identifier}.default.src.split(\"/\").splice(-1)[0]}}`,", | ||
| `?${{mod.src.split(\"/\").splice(-1)[0]}}`,", |
Member
There was a problem hiding this comment.
Preexisting, but this src.split(\"/\").splice(-1)[0] feels weird
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
sokra
reviewed
Mar 20, 2026
mischnic
force-pushed
the
mischnic/lazy-metadata-require
branch
from
c73c550 to
911a81d
Compare
mischnic
changed the title
sokra
approved these changes
Mar 20, 2026
ijjk
pushed a commit
that referenced
this pull request
Mar 20, 2026
A regression from #88487 1. Make metadata import lazy with `() => require()`, just like for the layout segments 2. Properly await the return value to better handle TLA modules This align with Webpack which does this: <img width="1535" height="509" alt="Bildschirmfoto 2026-03-20 um 11 58 00" src="https://github.com/user-attachments/assets/f2864c86-ccce-4884-8417-c8ae06c05f78" /> Closes PACK-6927 Closes #91700 Closes #91676
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression from #88487
() => require(), just like for the layout segmentsThis align with Webpack which does this:
Closes PACK-6927
Closes #91700
Closes #91676