Add secure option for external rewrites to support self-signed certificates#78566
Open
dale-lakes wants to merge 5 commits intovercel:canaryfrom
Open
Add secure option for external rewrites to support self-signed certificates#78566dale-lakes wants to merge 5 commits intovercel:canaryfrom
dale-lakes wants to merge 5 commits intovercel:canaryfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a new
secureoption to the rewrites configuration, specifically for external rewrites (those withdestinationstarting withhttp://orhttps://). This option allows developers to control whether the proxy should verify SSL certificates when proxying requests to external destinations.Why?
This change addresses a long-standing issue where Next.js users couldn't proxy to servers with self-signed certificates in development environments. The original issue #48117 and subsequent discussion #49546 highlight this need, where developers working with local development servers using self-signed certificates were unable to use Next.js's rewrite functionality.
How?
Added a new
securefield to theRewritetype in multiple locations:next-core/src/next_config.rspackages/next/src/lib/load-custom-routes.tspackages/next/src/server/config-schema.tsUpdated the proxy request handling to respect this option:
proxyRequestfunction to accept thesecureparametersecureoptionAdded comprehensive documentation:
Example Usage
Fixes #48117
Fixes #49546