Revert Rust upgrade to nightly-2025-04-10 #78062
Merged
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests Passed |
kdy1
approved these changes
Apr 11, 2025
Merge activity
|
wbinnssmith
added a commit
that referenced
this pull request
Apr 14, 2025
This reverts commit dedf6d3.
wbinnssmith
added a commit
that referenced
this pull request
Apr 14, 2025
This reverts commit dedf6d3. Test Plan: Confirmed that 2025-04-10 crashed and created rustc-ice dumps whenever rust-analyzer was used, even lightly. Confirmed that 2025-04-14 no longer produces these files after multiple restarts and light changes to some turbopack crates.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts most of #78039, I've kept the applied clippy suggestions though.
Unfortunately, a rustc ICE crash that was rare before now happens constantly, both when building and inside rust-analyzer, making everything just unusable.
Closes PACK-4333