Turbopack: support for CSS Modules in Data URLs #78040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
sokra
changed the title
sokra
approved these changes
Apr 11, 2025
mischnic
approved these changes
Apr 11, 2025
Tests Passed |
|
It's supposed to work, but I guess we don't test this case yet and it might be broken... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Contributors
Adding a feature
What?
This PR adds support for CSS Modules in Data URLs by adding the
text/css+modulecontent type to the module rules that handle CSS modulesWhy?
This enables new use cases for CSS Modules without requiring physical files, which is particularly useful for tooling that needs to generate CSS Modules programmatically
How?
The implementation extends existing rule conditions in the Turbopack module options to recognize the "text/css+module" content type, following the same pattern used for regular CSS in data URLs. Test cases have been added to verify both regular and base64-encoded CSS module data URLs work correctly