Skip to content

Turbopack: asset ident instead of chunk item ID in CSS #78018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Turbopack: asset ident instead of chunk item ID in CSS #78018

merged 2 commits into from
Apr 10, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Apr 10, 2025 •
edited by padmaia
Loading

This is absolutely useless with numerical ids (prod build with turbopackMinify: false):

/* 51318 */
.base2-module__zzC_ua__base {
  color: #ff0200;
}


/* 29244 */
.base2-scss-module-scss-module__JjfRsa__base {
  color: #ff0300;
}


/* 85234 */
.base-module__DNnTeq__base {
  color: red;
}


/* 29244 */
.base2-scss-module-scss-module__JjfRsa__base {
  color: #ff0300;
}

Closes PACK-4319

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Apr 10, 2025
@mischnic Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic mentioned this pull request Apr 10, 2025
Draft
@mischnic mischnic marked this pull request as ready for review April 10, 2025 09:50
@mischnic mischnic requested a review from sokra April 10, 2025 09:50
@mischnic mischnic merged commit 66ecb87 into canary Apr 10, 2025
128 of 129 checks passed
@mischnic mischnic deleted the mischnic/string-css-comment branch April 10, 2025 10:27
@mischnic Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 10, 6:27 AM EDT: A user merged this pull request with Graphite.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @sokra @ijjk