Handle more known protocols in stackframe locations by eps1lon · Pull Request #76086 · vercel/next.js

eps1lon · 2025-02-15T22:18:54Z

Adds support for turbopack:, rsc:, and webpack-internal:.

It should really just parse any valid URL scheme.
Riskier and harder to implement for Gecko though so restricting this fix to known cases for now.

eps1lon · 2025-02-15T22:19:17Z

Handle more known protocols in stackframe locations #76086 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

eps1lon · 2025-02-15T22:21:26Z

packages/next/src/client/components/react-dev-overlay/internal/helpers/webpack-module-path.ts

 const replacementRegExes = [
-  /^(rsc:\/\/React\/[^/]+\/)/,
  /^webpack-internal:\/\/\/(\([\w-]+\)\/)?/,
  /^(webpack:\/\/\/|webpack:\/\/(_N_E\/)?)(\([\w-]+\)\/)?/,


These should also go on the chopping block. They mask sourcemapping bugs.

ijjk · 2025-02-15T22:25:36Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
buildDuration	19s	16.8s	N/A
buildDurationCached	15.9s	13.5s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	433ms	445ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
5306-HASH.js gzip	55.2 kB	55.2 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.9 kB	34.9 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	55.1 kB	55.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	327 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
index.html gzip	523 B	521 B	N/A
link.html gzip	539 B	535 B	N/A
withRouter.html gzip	520 B	517 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
middleware-b..fest.js gzip	675 B	673 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.4 kB	31.4 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
app-page-exp...dev.js gzip	395 kB	395 kB	N/A
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	384 kB	384 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	39.1 kB	39.1 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	898 kB	898 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-15-handle_more_known_protocols_in_stackframe_locations	Change
0.pack gzip	2.12 MB	2.12 MB	⚠️ +2.44 kB
index.pack gzip	76.7 kB	77.1 kB	⚠️ +366 B
Overall change	2.19 MB	2.2 MB	⚠️ +2.8 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 3ed519c

ijjk · 2025-02-15T22:25:49Z

Tests Passed

It's indicative that there's a sourcemapping issue.

Adds support for `turbopack:`, `rsc:`, and `webpack-internal:`. It should really just parse any valid URL scheme. Riskier and harder to implement for Gecko though so restricting this fix to known cases for now.

eps1lon · 2025-02-15T23:28:03Z

patches/[email protected]

errwischt/stacktrace-parser#48 + handling turbopack and webpack-internal

ijjk added created-by: Next.js team PRs by the Next.js team. tests type: next labels Feb 15, 2025

eps1lon mentioned this pull request Feb 15, 2025

[dev-overlay] Stop hiding rsc: protocol #76083

Closed

eps1lon changed the title ~~[dev-overlay] Stop hiding rsc: protocol~~ Handle more known protocols in stackframe locations Feb 15, 2025

eps1lon commented Feb 15, 2025

View reviewed changes

eps1lon added 2 commits February 15, 2025 23:28

[dev-overlay] Stop hiding rsc: protocol

3cdefc5

It's indicative that there's a sourcemapping issue.

Handle more known protocols in stackframe locations

3ed519c

Adds support for `turbopack:`, `rsc:`, and `webpack-internal:`. It should really just parse any valid URL scheme. Riskier and harder to implement for Gecko though so restricting this fix to known cases for now.

eps1lon force-pushed the sebbie/02-15-handle_more_known_protocols_in_stackframe_locations branch from c1e35fc to 3ed519c Compare February 15, 2025 22:40

eps1lon marked this pull request as ready for review February 15, 2025 23:25

eps1lon requested review from huozhi and sokra February 15, 2025 23:26

eps1lon commented Feb 15, 2025

View reviewed changes

patches/[email protected]

Copy link

Member Author

eps1lon Feb 15, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errwischt/stacktrace-parser#48 + handling turbopack and webpack-internal

huozhi approved these changes Feb 17, 2025

View reviewed changes

eps1lon merged commit 1110272 into canary Feb 17, 2025
131 checks passed

eps1lon deleted the sebbie/02-15-handle_more_known_protocols_in_stackframe_locations branch February 17, 2025 12:32

github-actions bot added the locked label Mar 4, 2025

github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle more known protocols in stackframe locations#76086

Handle more known protocols in stackframe locations#76086
eps1lon merged 2 commits intocanaryfrom
sebbie/02-15-handle_more_known_protocols_in_stackframe_locations

eps1lon commented Feb 15, 2025 •

edited

Loading

Uh oh!

eps1lon commented Feb 15, 2025

Uh oh!

eps1lon Feb 15, 2025

Uh oh!

ijjk commented Feb 15, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 15, 2025 •

edited

Loading

Uh oh!

eps1lon Feb 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eps1lon commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Feb 15, 2025

Uh oh!

eps1lon Feb 15, 2025

Choose a reason for hiding this comment

Uh oh!

ijjk commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

Uh oh!

ijjk commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

eps1lon Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eps1lon commented Feb 15, 2025 •

edited

Loading

ijjk commented Feb 15, 2025 •

edited

Loading

ijjk commented Feb 15, 2025 •

edited

Loading

eps1lon Feb 15, 2025 •

edited

Loading