[dev-overlay] Stop hiding `rsc:` protocol by eps1lon · Pull Request #76083 · vercel/next.js

eps1lon · 2025-02-15T20:35:35Z

It's indicative that there's a sourcemapping issue.

It was hiding the bug we fixed by supporting rsc: protocol in the stacktrace parser: #76086

eps1lon · 2025-02-15T20:35:54Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-15T20:38:34Z

Failing test suites

Commit: 0ec9937

pnpm test test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > production mode > should have shown errors during build

Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.2.0-canary.61·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
 ✓ Compiled successfully
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/cat\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:106:1695)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:107:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:109:142)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2663:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:89:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:106:13)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:157:20)
  at async exportPage (../packages/next/dist/export/worker.js:358:18)
  Export encountered an error on /cat, exiting the build.
   ⨯ Next.js build worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/non-root-project-monorepo/non-root-project-monorepo.test.ts

non-root-project-monorepo > source-maps > should work on RSC

Expand output

● non-root-project-monorepo › source-maps › should work on RSC

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `non-root-project-monorepo source-maps should work on RSC 2`

- Snapshot  - 2
+ Received  + 2

@@ -1,11 +1,11 @@
  eval
  app/separate-file.ts (1:11)
  <unknown>
- rsc)/./app/separate-file.ts (rsc://React/Server/file://<full-path>/apps/web/.next/server/app/source-maps-rsc/page.js
+ rsc)/./app/separate-file.ts (rsc://React/Server/file://<full-path>/apps/web/.next/server/app/source-maps-rsc/page.js?3 (149:1)
  __webpack_require__
- file://<full-path>/apps/web/.next/server/webpack-runtime.js
+ rsc:/Server/file://<full-path>/apps/web/.next/server/webpack-runtime.js (33:42)
  innerArrowFunction
  app/source-maps-rsc/page.tsx (14:3)
  innerFunction
  app/source-maps-rsc/page.tsx (10:3)
  Page

  136 |           // TODO webpack runtime code shouldn't be included in stack trace
  137 |           expect(normalizeStackTrace(await getRedboxCallStack(browser)))
> 138 |             .toMatchInlineSnapshot(`
      |              ^
  139 |            "eval
  140 |            app/separate-file.ts (1:11)
  141 |            <unknown>

  at Object.toMatchInlineSnapshot (e2e/app-dir/non-root-project-monorepo/non-root-project-monorepo.test.ts:138:14)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-02-15T20:43:52Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
buildDuration	27.5s	25.4s	N/A
buildDurationCached	21.4s	20.1s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	516ms	712ms	⚠️ +196ms

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
5306-HASH.js gzip	55.2 kB	55.2 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	246 B	N/A
main-HASH.js gzip	34.9 kB	34.9 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	54.9 kB	54.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	327 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
index.html gzip	523 B	521 B	N/A
link.html gzip	539 B	535 B	N/A
withRouter.html gzip	520 B	517 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
middleware-b..fest.js gzip	676 B	674 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.4 kB	31.4 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
app-page-exp...dev.js gzip	395 kB	395 kB	N/A
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	384 kB	384 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	39.1 kB	39.1 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	898 kB	898 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol	Change
0.pack gzip	2.12 MB	2.12 MB	⚠️ +165 B
index.pack gzip	77.5 kB	76.2 kB	N/A
Overall change	2.12 MB	2.12 MB	⚠️ +165 B

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 0ec9937

It's indicative that there's a sourcemapping issue.

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 15, 2025

eps1lon mentioned this pull request Feb 15, 2025

Create valid URLs in source map sources with Turbopack #76075

Merged

eps1lon force-pushed the sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol branch from 4ffadce to 77d9b2c Compare February 15, 2025 21:19

eps1lon mentioned this pull request Feb 15, 2025

Handle more known protocols in stackframe locations #76085

Closed

eps1lon added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Feb 15, 2025

eps1lon changed the base branch from sebbie/valid-url-turbopack to graphite-base/76083 February 15, 2025 21:37

eps1lon force-pushed the graphite-base/76083 branch from 9edc662 to dcffe81 Compare February 15, 2025 21:38

eps1lon force-pushed the sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol branch from 77d9b2c to b8f4b3d Compare February 15, 2025 21:38

eps1lon changed the base branch from graphite-base/76083 to canary February 15, 2025 21:38

[dev-overlay] Stop hiding rsc: protocol

0ec9937

It's indicative that there's a sourcemapping issue.

eps1lon force-pushed the sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol branch from b8f4b3d to 0ec9937 Compare February 15, 2025 21:38

eps1lon closed this Feb 15, 2025

eps1lon deleted the sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol branch February 15, 2025 22:18

github-actions bot added the locked label Mar 2, 2025

github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev-overlay] Stop hiding `rsc:` protocol#76083

[dev-overlay] Stop hiding `rsc:` protocol#76083
eps1lon wants to merge 1 commit intocanaryfrom
sebbie/02-15-_dev-overlay_stop_hiding_rsc_protocol

eps1lon commented Feb 15, 2025 •

edited

Loading

Uh oh!

eps1lon commented Feb 15, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 15, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eps1lon commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

ijjk commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eps1lon commented Feb 15, 2025 •

edited

Loading

eps1lon commented Feb 15, 2025 •

edited

Loading

ijjk commented Feb 15, 2025 •

edited

Loading

ijjk commented Feb 15, 2025 •

edited

Loading