ensure export workers that are killed bubble up to parent process #70997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Tests Passed |
ijjk
approved these changes
Oct 9, 2024
ztanner
deleted the
10-08-ensure_export_workers_that_are_killed_bubble_up_to_parent_process
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a static worker exits, we log the error but it doesn't get propagated to the parent process, which can cause the build to hang. If we're going to log an error about a static worker being forced to exit, this calls exit on the parent process.
Closes NDX-364