Implement get-params for rsc#65922
Closed
alexdln wants to merge 1 commit into
Closed
Conversation
alexdln
requested review from
feedthejim,
huozhi,
ijjk,
shuding,
timneutkens,
wyattjoh and
ztanner
as code owners
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Contributor
|
It appears you have to disable the router cache completely for this to work, and it only works in prod mode: /**
* @type {import('next').NextConfig}
*/
module.exports = {
experimental: {
staleTimes: { static: 0, dynamic: 0 },
},
};But the fact that this even works is amazing. I don't know the internals but, purely from the concept of partial rendering, this shouldn't even be possible, yet it actually works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Just wanna leave a PR here that the technical basis for obtaining params in server components already exist.
Very basic implementation, without tests and errors. If you know about problems and risks that I don't know - please tell me, perhaps I will be able to deal with their elaboration and find a solution that suits you. After I will write all the tests and necessary logic.
Fixes #58862