Skip to content

Clean up builtin modularizeImports configs#59294

Merged
shuding merged 2 commits into
canaryfrom
shu/b830
Dec 5, 2023
Merged

Clean up builtin modularizeImports configs#59294
shuding merged 2 commits into
canaryfrom
shu/b830

Conversation

@shuding

@shuding shuding commented Dec 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Most of them can now be handled by optimizePackageImports as I manually tested them locally. The main benefit is that structural updates from these libs won't affect our internal configurations anymore, as they're automatic with the new approach. The little downside is that the automatic way is a bit slower than the modularizeImports config as it needs to do extra analyzation. But overall, this is a good direction.

Depends on #59254.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 5, 2023
@ghost

ghost commented Dec 5, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @huozhi:

packages/next/src/server/config.ts

@ijjk

ijjk commented Dec 5, 2023

Copy link
Copy Markdown
Member

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js shu/b830 Change
buildDuration 11s 10.9s N/A
buildDurationCached 6.2s 6.3s ⚠️ +113ms
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 423ms 423ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/b830 Change
170-HASH.js gzip 30.6 kB 30.6 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/b830 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js shu/b830 Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.6 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B ✓
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.57 kB 1.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js shu/b830 Change
_buildManifest.js gzip 483 B 483 B ✓
Overall change 483 B 483 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/b830 Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js shu/b830 Change
edge-ssr.js gzip 93.7 kB 93.5 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js shu/b830 Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js shu/b830 Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 93.8 kB 93.8 kB ✓
app-page-tur..prod.js gzip 94.5 kB 94.5 kB ✓
app-page-tur..prod.js gzip 89.1 kB 89.1 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.4 kB 88.4 kB ✓
app-route-ex...dev.js gzip 24.2 kB 24.2 kB ✓
app-route-ex..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.9 kB 16.9 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route.ru...dev.js gzip 23.6 kB 23.6 kB ✓
app-route.ru..prod.js gzip 16.4 kB 16.4 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 930 kB 930 kB ✓
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: cef6e47

@shuding shuding merged commit 1436a36 into canary Dec 5, 2023
@shuding shuding deleted the shu/b830 branch December 5, 2023 16:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes
@timneutkens timneutkens Awaiting requested review from timneutkens
@ijjk ijjk Awaiting requested review from ijjk
@feedthejim feedthejim Awaiting requested review from feedthejim
@ztanner ztanner Awaiting requested review from ztanner
@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuding @ijjk @huozhi