fix dev parallelism in daily turbopack tests#59287
Merged
Merged
Conversation
ForsakenHarmony
requested review from
lydiahallie and
manovotny
and removed request for
a team
ForsakenHarmony
commented
Dec 5, 2023
| sudo npx playwright install-deps && pnpm playwright install | ||
| NEXT_TEST_MODE=dev TURBOPACK=1 node run-tests.js -g ${{ matrix.group }}/3 -c ${TEST_CONCURRENCY} --type development | ||
| ls test/turbopack-test-junit-report | ||
| NEXT_TEST_MODE=dev TURBOPACK=1 node run-tests.js -g ${{ matrix.group }}/6 -c ${TEST_CONCURRENCY} --type development |
Contributor
Author
There was a problem hiding this comment.
This line is the fix, the rest is some cleanup
ForsakenHarmony
commented
Dec 5, 2023
| continue-on-error: true | ||
| env: | ||
| # marker to parse log output, do not delete / change. | ||
| NEXT_INTEGRATION_TEST: true |
Contributor
Author
There was a problem hiding this comment.
I can't find anything using this across both repos, so I've removed it for now
timneutkens
approved these changes
Dec 5, 2023
Member
Tests Passed |
Member
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes the retry running on forks (hopefully for real this time)
Closes PACK-2087