Skip to content

Delete unused static prefetch code#58783

Merged
wyattjoh merged 3 commits into
canaryfrom
chore/delete-unused-prefetch-code
Dec 4, 2023
Merged

Delete unused static prefetch code#58783
wyattjoh merged 3 commits into
canaryfrom
chore/delete-unused-prefetch-code

Conversation

@wyattjoh

@wyattjoh wyattjoh commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This removes the dead code related to prefetching until it can reland.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 22, 2023
@wyattjoh

wyattjoh commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@wyattjoh wyattjoh force-pushed the chore/delete-unused-prefetch-code branch from 85be246 to 74976c9 Compare November 22, 2023 18:09
@ijjk

ijjk commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
buildDuration 10.6s 10.6s N/A
buildDurationCached 6s 5.9s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 427ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
199-HASH.js gzip 30.6 kB 30.6 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 100 kB 100 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB ✓
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B ✓
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.17 kB 3.17 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
index.html gzip 528 B 527 B N/A
link.html gzip 538 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
edge-ssr.js gzip 92.6 kB 92.7 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js chore/delete-unused-prefetch-code Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 93.8 kB 93.8 kB ✓
app-page-tur..prod.js gzip 94.5 kB 94.5 kB ✓
app-page-tur..prod.js gzip 89.1 kB 89.1 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.4 kB 88.4 kB ✓
app-route-ex...dev.js gzip 24.2 kB 24.2 kB ✓
app-route-ex..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.9 kB 16.9 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route.ru...dev.js gzip 23.6 kB 23.6 kB ✓
app-route.ru..prod.js gzip 16.4 kB 16.4 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.3 kB 49.3 kB ✓
Overall change 930 kB 930 kB ✓
Commit: 0e5b026

@wyattjoh wyattjoh marked this pull request as ready for review November 22, 2023 18:56
@ijjk

ijjk commented Nov 27, 2023

Copy link
Copy Markdown
Member

Failing test suites

Commit: 6045d7f

pnpm test-dev test/e2e/app-dir/app-compilation/index.test.ts

  • app dir > HMR > should not cause error when removing loading.js
Expand output

● app dir › HMR › should not cause error when removing loading.js

TIMED OUT: hello from new page

hello from slow page

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (e2e/app-dir/app-compilation/index.test.ts:44:11)

Read more about building and testing Next.js in contributing.md.

@wyattjoh wyattjoh enabled auto-merge (squash) December 4, 2023 17:47
@wyattjoh wyattjoh merged commit f998127 into canary Dec 4, 2023
@wyattjoh wyattjoh deleted the chore/delete-unused-prefetch-code branch December 4, 2023 17:54
@ztanner ztanner mentioned this pull request Dec 6, 2023
Merged
ztanner added a commit that referenced this pull request Dec 6, 2023
@ztanner
remove additional static prefetch code (#59313)
59f7ca8 
This is a continuation from #58783
to remove the remaining code related to static prefetching.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuding shuding shuding approved these changes
@ijjk ijjk ijjk approved these changes
@timneutkens timneutkens Awaiting requested review from timneutkens
@huozhi huozhi Awaiting requested review from huozhi
@feedthejim feedthejim Awaiting requested review from feedthejim
@ztanner ztanner Awaiting requested review from ztanner

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyattjoh @ijjk @shuding