update: Firebase link to with-firebase example#58621
Merged
Merged
Conversation
JackieLi565
requested review from
S3Prototype and
StephDietz
and removed request for
a team
leerob
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The
Firebaselink leads to a 404 page (https://github.com/vercel/next.js/tree/canary/examples/with-firebase-authentication)Why?
The other links within the same drop down such as
SupabaseandUserbaselead to awith-[item name]example page. I think (https://github.com/vercel/next.js/tree/canary/examples/with-firebase) should be attached to the Firebase link as it is inline with the other links as well!Issue can be found at (#58619)