fix: moduleResolution: bundler support in tsconfig.json#50289
Closed
kvnwolf wants to merge 3 commits intovercel:canaryfrom
Closed
fix: moduleResolution: bundler support in tsconfig.json#50289kvnwolf wants to merge 3 commits intovercel:canaryfrom
moduleResolution: bundler support in tsconfig.json#50289kvnwolf wants to merge 3 commits intovercel:canaryfrom
Conversation
kvnwolf
requested review from
a team,
feedthejim,
huozhi,
ijjk,
shuding and
timneutkens
as code owners
Contributor
Author
Member
|
Looks like CI is failing. Can we make sure this change is compatible with TS 4 as well? |
1 task
styfle
changed the title
moduleResolution: bundler support in tsconfig.json
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
We need to upgrade TypeScript to land the following fixes: - #50289 - #48018 And it should fix async components: - https://twitter.com/sebsilbermann/status/1664356039876124672 Also see this related TS 5.0 issue: - microsoft/TypeScript#53402
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
- Fixes #47858 - Closes #50289 fix #47858 fix NEXT-1281 Co-authored-by: Kevin Wolf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47858
link NEXT-1281