Skip to content

Conversation

@Wattyyy
Copy link

@Wattyyy Wattyyy commented Jul 12, 2022

The official document says about next-env.d.ts, "As such this file should not be committed and should be ignored by version control.". However, after executing npx create-next-app --ts, generated .gitignore omits next-env.d.ts. Some developers add next-env.d.ts to .gitignore manually. So, it would be better if the .gitignore template of create-next-app had next-env.d.ts.
Feel free to close if this change is wrong.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 12, 2022
@Wattyyy Wattyyy changed the title Add next-env.d.ts to the .gitignore template of create-next-app Add next-env.d.ts to the .gitignore template of create-next-app Jul 12, 2022
@ijjk ijjk mentioned this pull request Jul 27, 2022
2 tasks
@ijjk ijjk closed this in #39051 Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

create-next-app Related to our CLI tool for quickly starting a new Next.js application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants