Repository navigation
fix: persist cacheControl for Pages Router ISR entries in FileSystemC… - #100495
Merged
unstubbable merged 1 commit intoOct 21, 2026
Merged
Conversation
Contributor
Tests PassedCommit: 6444c4a |
unstubbable
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixed ISR cache lifetime persistence for Pages Router pages using the default
FileSystemCacheimplementation.Why?
Pages Router ISR cache entries did not persist their revalidation interval to disk. After restarting the server, the cache lifetime defaulted to 1 second instead of the configured
revalidatevalue.As a result, previously generated pages could be treated as stale immediately after a restart, and the expected
Cache-Controlheader was not preserved.This complements #99289, which addressed the same issue for the App Router, and covers the missing Pages Router case. See also #99288.
How?
test/production/app-dir/isr-cache-control-restart/to verify cache behavior after a server restart.Before the fix, the test failed because the first request after restarting the server returned a
STALEcache status instead ofHIT.Verified that all 5 tests pass with both Turbopack and webpack using:
pnpm test-start-turbopnpm test-start-webpack