enhance: upgrade local ts by huozhi · Pull Request #674 · vercel/ncc

huozhi · 2021-03-23T15:56:14Z

Fixes #606

bump ts-loader version
bump built-in ts version
override incremental option to false

styfle

Thanks! Looks like CI is failing though.

huozhi · 2021-03-24T05:24:17Z

The inproper ts version in test directory lead to test failures

@styfle @guybedford, if I want to upgrade the ts lib assets generated in test/integration/node_modules/typescript/, (introduced #252) what's the proper coommand I should run? I tried ./dist/ncc/cli.js build src/typescript.js -o test/integration/node_modules/typescript/ -m but it emits unexpected assets

guybedford · 2021-03-24T11:56:15Z

@huozhi that sounds right to me, but TypeScript is a very complex build for ncc already - just updating TypeScript is a job unto itself. Is it working?

styfle

I'm not sure if a symlink for test/integration/node_modules/typescript/index.js is correct here. What do you think @guybedford ?

guybedford · 2021-03-24T18:27:55Z

@styfle the symlink approach seems fine to me actually. Note we should be sure to thoroughly test the TypeScript upgrade here manually before releasing, and it is a major release to upgrade TypeScript.

styfle · 2021-03-24T18:31:19Z

@guybedford All the CI tests are passing. Any other TS tests you have in mind?

guybedford · 2021-03-24T18:51:52Z

@styfle we may be missing test coverage of the bundled typescript version. That is, we should add a test that does a similar symlink trick, but to ./dist/typescript instead. Because otherwise node_modules/typescript will always be used as a local TypeScript always takes precedence so does in these tests as well.

huozhi

this ts upgration is truly a big gap (from 3.2.2 to 3.9.9).
one idea is to only upgrade to 3.4 to support incremental option, the gap is small.
another option is to change purpose of this PR to "upgrade local provided ts" and release later.

which one do you prefer?

codecov-io · 2021-03-28T09:35:18Z

Codecov Report

Merging #674 (9678c2b) into master (630d44e) will decrease coverage by 1.51%.
The diff coverage is 77.93%.

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   74.93%   73.41%   -1.52%     
==========================================
  Files          13       13              
  Lines         399      474      +75     
==========================================
+ Hits          299      348      +49     
- Misses        100      126      +26

Impacted Files	Coverage Δ
src/@@notfound.js	`0.00% <0.00%> (ø)`
src/typescript.js	`80.00% <75.00%> (+2.22%)`	⬆️
src/index.js	`79.32% <76.98%> (-4.61%)`	⬇️
src/cli.js	`62.85% <91.66%> (+0.50%)`	⬆️
src/loaders/empty-loader.js	`100.00% <100.00%> (ø)`
src/loaders/relocate-loader.js	`100.00% <100.00%> (ø)`
src/utils/get-package-base.js	`0.00% <0.00%> (-37.50%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bdfc5...9678c2b. Read the comment docs.

styfle · 2021-03-30T14:10:49Z

Looks good! Just missing this: #674 (comment)

Also in regard to the TS version, we bundle TS so its not going to use any version besides the one defined in devDependencies (3.6.5 in your PR or rather the version in the lock file)

huozhi · 2021-04-01T14:01:06Z

I'm kinda unclear about the approach of testing ./dist/typescript.js with symlink, would you mind clarifying it a bit more specific? I can work on that then. Thanks

guybedford · 2021-04-01T21:09:50Z

@huozhi perhaps a symlink is the wrong direction actually - instead we just want to not load the local test/node_modules/typescript by ensuring that TypeScript cannot be located.

One way to do this would be to construct a tmp folder at the system root - /tmp/s9d8f0s9d8/test.ts and then execute that ts file. Because there is no node_modules containing typescript from such a path, this will force ncc to use its local inbuilt typescript version and thus test that.

Alternatively, simply running ncc from a difference cwd could also do this:

cd /
ncc run /path/to/ncc/test/unit/ts-ext/test.ts

Tests like the above might be possible to construct with the test/cli.js file (https://github.com/vercel/ncc/blob/master/test/cli.js) by adding a cwd option support to that test system.

So that's two possible ways to test this, basically if ncc finds a node_modules/typescript in cwd, it uses it, and notes that it is in the console. And because ncc/node_modules and ncc/test/node_modules both have local typescript versions, we are never testing the case where it isn't found. If you can think of another way apart from my above two suggestions to catch this other case feel free to try something else too and just let me know if I can clarify further at all.

huozhi · 2021-04-02T11:02:07Z

I use the TYPESCRIPT_LOOKUP_PATH env as override option for tests. If the folder is invalid ncc can fallback to built-in ts lib. hope it's sth you're expecting.

guybedford

Looks great, thanks for your work on this!

Co-authored-by: Steven <[email protected]>

styfle

Great work, thanks! 🎉

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@vercel/ncc](https://github.com/vercel/ncc) | [`^0.24.1` → `^0.38.0`](https://renovatebot.com/diffs/npm/@vercel%2fncc/0.24.1/0.38.4) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fncc/0.38.4?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fncc/0.24.1/0.38.4?slim=true) | --- ### Release Notes <details> <summary>vercel/ncc (@vercel/ncc)</summary> ### [`v0.38.4`](https://github.com/vercel/ncc/releases/tag/0.38.4) [Compare Source](vercel/ncc@0.38.3...0.38.4) ##### Bug Fixes - **cjs-build:** enable evaluating import.meta in cjs build ([#1236](vercel/ncc#1236)) ([e72d34d](vercel/ncc@e72d34d)), closes [/github.com/vercel/ncc/pull/897#discussion\_r836916315](https://github.com//github.com/vercel/ncc/pull/897/issues/discussion_r836916315) [#1019](vercel/ncc#1019) ### [`v0.38.3`](https://github.com/vercel/ncc/releases/tag/0.38.3) [Compare Source](vercel/ncc@0.38.2...0.38.3) ##### Bug Fixes - add missing `--asset-builds` to cli help message ([#1228](vercel/ncc#1228)) ([84f8c52](vercel/ncc@84f8c52)) ### [`v0.38.2`](https://github.com/vercel/ncc/releases/tag/0.38.2) [Compare Source](vercel/ncc@0.38.1...0.38.2) ##### Bug Fixes - **deps:** update webpack to v5.94.0, terser to v5.33.0 ([#1213](vercel/ncc#1213)) ([158a1fd](vercel/ncc@158a1fd)), closes [#1193](vercel/ncc#1193) [#1194](vercel/ncc#1194) [#1177](vercel/ncc#1177) [#1204](vercel/ncc#1204) [#1195](vercel/ncc#1195) Huge thanks to [@theoludwig](https://github.com/theoludwig) 🎉 ### [`v0.38.1`](https://github.com/vercel/ncc/releases/tag/0.38.1) [Compare Source](vercel/ncc@0.38.0...0.38.1) ##### Bug Fixes - sourcemap sources removes webpack path ([#1122](vercel/ncc#1122)) ([ce5984e](vercel/ncc@ce5984e)), closes [#1011](vercel/ncc#1011) [#1121](vercel/ncc#1121) ### [`v0.38.0`](https://github.com/vercel/ncc/releases/tag/0.38.0) [Compare Source](vercel/ncc@0.37.0...0.38.0) ##### Features - Log minification error when `--debug` ([#1102](vercel/ncc#1102)) ([e2779f4](vercel/ncc@e2779f4)) ### [`v0.37.0`](https://github.com/vercel/ncc/releases/tag/0.37.0) [Compare Source](vercel/ncc@0.36.1...0.37.0) ##### Features - add support for TypeScript 5.0's array extends in tsconfig ([#1105](vercel/ncc#1105)) ([f898f8e](vercel/ncc@f898f8e)) ### [`v0.36.1`](https://github.com/vercel/ncc/releases/tag/0.36.1) [Compare Source](vercel/ncc@0.36.0...0.36.1) ##### Bug Fixes - add missing pr title lint action ([#1032](vercel/ncc#1032)) ([c2d03cf](vercel/ncc@c2d03cf)) - add `ncc --version` and `ncc --help` ([#1030](vercel/ncc#1030)) ([d38b619](vercel/ncc@d38b619)) ### [`v0.36.0`](https://github.com/vercel/ncc/releases/tag/0.36.0) [Compare Source](vercel/ncc@0.34.0...0.36.0) ##### Bug Fixes - gitignore should include release.config.js ([#1016](vercel/ncc#1016)) ([44e2eac](vercel/ncc@44e2eac)) - node 18 by update source-map used by Terser to 0.7.4 ([#999](vercel/ncc#999)) ([2f69f83](vercel/ncc@2f69f83)) ##### Features - add semantic-release to autopublish ([#1015](vercel/ncc#1015)) ([be3405d](vercel/ncc@be3405d)), closes [#1000](vercel/ncc#1000) ### [`v0.34.0`](https://github.com/vercel/ncc/releases/tag/0.34.0) [Compare Source](vercel/ncc@0.33.4...0.34.0) ##### Changes Add support for TS 4.7 - Chore(deps-dev): bump ts-loader from 8.3.0 to 9.3.0: [#921](vercel/ncc#921) - Chore(deps-dev): bump express from 4.17.1 to 4.18.1: [#917](vercel/ncc#917) - Chore: add `memory-fs` to the devDependencies: [#927](vercel/ncc#927) ##### Credits Huge thanks to [@stscoundrel](https://github.com/stscoundrel) and [@shogo82148](https://github.com/shogo82148) for helping! ### [`v0.33.4`](https://github.com/vercel/ncc/releases/tag/0.33.4) [Compare Source](vercel/ncc@0.33.3...0.33.4) ##### Changes - Fix: Add missing variable declaration: [#773](vercel/ncc#773) - Chore: add windows to CI: [#896](vercel/ncc#896) - Chore: bump webpack-asset-relocator-loader to 1.7.2: [#912](vercel/ncc#912) - Chore(deps-dev): bump vm2 from 3.9.4 to 3.9.6: [#872](vercel/ncc#872) - Chore(deps): bump url-parse from 1.5.3 to 1.5.7: [#875](vercel/ncc#875) - Chore(deps): bump url-parse from 1.5.7 to 1.5.10: [#879](vercel/ncc#879) - Chore(deps-dev): bump stripe from 8.167.0 to 8.205.0: [#882](vercel/ncc#882) - Chore(deps-dev): bump typescript from 4.4.2 to 4.6.2: [#881](vercel/ncc#881) - Chore(deps-dev): bump twilio from 3.66.1 to 3.75.0: [#884](vercel/ncc#884) - Chore(deps): bump actions/setup-node from 2 to 3: [#880](vercel/ncc#880) - Chore(deps-dev): bump graphql from 15.5.1 to 15.8.0: [#885](vercel/ncc#885) - Chore: replace deprecated String.prototype.substr(): [#894](vercel/ncc#894) - Chore(deps): bump actions/checkout from 2 to 3: [#902](vercel/ncc#902) - Chore(deps-dev): bump [@azure/cosmos](https://github.com/azure/cosmos) from 3.12.3 to 3.15.1: [#905](vercel/ncc#905) - Chore(deps-dev): bump stripe from 8.205.0 to 8.214.0: [#906](vercel/ncc#906) - Chore(deps-dev): bump [@google-cloud/bigquery](https://github.com/google-cloud/bigquery) from 5.7.0 to 5.12.0: [#903](vercel/ncc#903) - Chore(deps-dev): bump tsconfig-paths from 3.10.1 to 3.14.1: [#904](vercel/ncc#904) ##### Credits Huge thanks to [@CommanderRoot](https://github.com/CommanderRoot) for helping! ### [`v0.33.3`](https://github.com/vercel/ncc/releases/tag/0.33.3) [Compare Source](vercel/ncc@0.33.2...0.33.3) ##### Patches - Fix: bump license-webpack-plugin: [#871](vercel/ncc#871) - Chore(deps): bump follow-redirects from 1.14.7 to 1.14.8: [#870](vercel/ncc#870) ### [`v0.33.2`](https://github.com/vercel/ncc/releases/tag/0.33.2) [Compare Source](vercel/ncc@0.33.1...0.33.2) ##### Patches - Fix: use `sha256` instead of deprecated `md5` for hash algorithm: [#868](vercel/ncc#868) - Fix: typo in build script: [#835](vercel/ncc#835) - Chore(test) Add Node.js 16 to CI: [#801](vercel/ncc#801) - Chore(deps): bump nodemailer from 6.5.0 to 6.7.2: [#833](vercel/ncc#833) - Chore(deps-dev): bump terser from 5.7.1 to 5.10.0: [#840](vercel/ncc#840) - Chore(deps-dev): bump passport from 0.4.1 to 0.5.2: [#839](vercel/ncc#839) - Chore(deps-dev): bump sequelize from 6.6.5 to 6.12.4: [#843](vercel/ncc#843) - Chore(deps-dev): bump analytics-node from 5.0.0 to 6.0.0: [#838](vercel/ncc#838) - Chore(deps): bump follow-redirects from 1.14.5 to 1.14.7: [#846](vercel/ncc#846) - Chore(deps): bump cached-path-relative from 1.0.2 to 1.1.0: [#854](vercel/ncc#854) - Chore(deps-dev): bump license-webpack-plugin from 2.3.20 to 4.0.1: [#859](vercel/ncc#859) - Chore(deps): bump simple-get from 3.1.0 to 3.1.1: [#864](vercel/ncc#864) - Chore(deps-dev): bump aws-sdk from 2.1024.0 to 2.1068.0: [#867](vercel/ncc#867) ##### Credits Huge thanks to [@shakefu](https://github.com/shakefu) for helping! ### [`v0.33.1`](https://github.com/vercel/ncc/releases/tag/0.33.1) [Compare Source](vercel/ncc@0.33.0...0.33.1) ##### Patches - Allow configuring mainFields for nccing browser modules: [#832](vercel/ncc#832) ### [`v0.33.0`](https://github.com/vercel/ncc/releases/tag/0.33.0) [Compare Source](vercel/ncc@0.32.0...0.33.0) ##### Minor Changes - Chore(deps-dev): bump [@vercel/webpack-asset-relocator-loader](https://github.com/vercel/webpack-asset-relocator-loader): [#826](vercel/ncc#826) - Fix: Fix source maps: [#818](vercel/ncc#818) - Feat: Allow using matches from externals for regex matching: [#825](vercel/ncc#825) ##### Patches - Chore(deps-dev): bump koa from 2.13.1 to 2.13.4: [#822](vercel/ncc#822) - Chore(deps-dev): bump mariadb from 2.5.4 to 2.5.5: [#823](vercel/ncc#823) ##### Credits Huge thanks to [@fenix20113](https://github.com/fenix20113) for helping! ### [`v0.32.0`](https://github.com/vercel/ncc/releases/tag/0.32.0) [Compare Source](vercel/ncc@0.31.1...0.32.0) ##### Changes - Feat: bump to webpack\@5.61.0: [#809](vercel/ncc#809) - Docs: add debug command description: [#800](vercel/ncc#800) - Chore(deps): bump object-path from 0.11.7 to 0.11.8: [#778](vercel/ncc#778) - Chore(deps): bump tmpl from 1.0.4 to 1.0.5: [#779](vercel/ncc#779) - Chore(deps-dev): bump vm2 from 3.9.3 to 3.9.4: [#795](vercel/ncc#795) - Chore(deps-dev): bump axios from 0.21.1 to 0.21.2: [#810](vercel/ncc#810) - Chore(deps-dev): bump aws-sdk from 2.958.0 to 2.1024.0: [#812](vercel/ncc#812) - Chore(deps-dev): bump webpack from 5.61.0 to 5.62.1: [#813](vercel/ncc#813) - Chore(deps): bump passport-oauth2 from 1.5.0 to 1.6.1: [#811](vercel/ncc#811) - Chore(deps): bump url-parse from 1.5.1 to 1.5.3: [#815](vercel/ncc#815) ##### Credits Huge thanks to [@fireairforce](https://github.com/fireairforce) and [@jesec](https://github.com/jesec) for helping! ### [`v0.31.1`](https://github.com/vercel/ncc/releases/tag/0.31.1) [Compare Source](vercel/ncc@0.31.0...0.31.1) ##### Patches - Fix `tsconfig.json` detection: [#770](vercel/ncc#770) ### [`v0.31.0`](https://github.com/vercel/ncc/releases/tag/0.31.0) [Compare Source](vercel/ncc@0.30.0...0.31.0) ##### Changes - Fix `compilerOptions` from `tsconfig.json`: [#766](vercel/ncc#766) - Bump typescript to 4.4.2: [#767](vercel/ncc#767) - Chore(deps-dev): bump graceful-fs from 4.2.6 to 4.2.8: [#761](vercel/ncc#761) - Chore(deps): bump tar from 4.4.15 to 4.4.19: [#763](vercel/ncc#763) - Chore(deps): bump object-path from 0.11.5 to 0.11.7: [#764](vercel/ncc#764) ### [`v0.30.0`](https://github.com/vercel/ncc/releases/tag/0.30.0) [Compare Source](vercel/ncc@0.29.2...0.30.0) ##### Changes - Major: Change asset builds to opt-in with new option `--asset-builds`: [#756](vercel/ncc#756) - Chore: bump typescript from 3.9.9 to 4.3.5: [#739](vercel/ncc#739) - Chore: bump codecov to 3.8.3: [#752](vercel/ncc#752) ##### Description Previous, `fs.readFile('./asset.js')` would compile `asset.js` instead of including as an asset. With this release, the default behavior has been changed to include `asset.js` as an asset only. If you want the old behavior, you can use the `--asset-builds` option. ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) for helping! ### [`v0.29.2`](https://github.com/vercel/ncc/releases/tag/0.29.2) [Compare Source](vercel/ncc@0.29.1...0.29.2) ##### Patches - Fix: ensure nested builds of `__nccwpck_require__`: [#751](vercel/ncc#751) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) for helping! ### [`v0.29.1`](https://github.com/vercel/ncc/releases/tag/0.29.1) [Compare Source](vercel/ncc@0.29.0...0.29.1) ##### Patches - Fix: add stringify-loader: [#742](vercel/ncc#742) - Fix: package.json asset type module setting: [#733](vercel/ncc#733) - Chore(deps): update dependencies: [#736](vercel/ncc#736) - Chore(deps): bump tar from 4.4.13 to 4.4.15: [#743](vercel/ncc#743) - Chore(deps): bump path-parse from 1.0.6 to 1.0.7: [#745](vercel/ncc#745) - Chore(deps-dev): bump pdfkit from 0.12.1 to 0.12.3: [#740](vercel/ncc#740) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford), [@mmorel-35](https://github.com/mmorel-35), and [@jpcloureiro](https://github.com/jpcloureiro) for helping! ### [`v0.29.0`](https://github.com/vercel/ncc/releases/tag/0.29.0) [Compare Source](vercel/ncc@0.28.6...0.29.0) ##### Changes - Major: output ESM for `.mjs` or `type=module` builds: [#720](vercel/ncc#720) - Feat: update to webpack-asset-reloactor-loader\@1.5.0: [#718](vercel/ncc#718) - Feat: update to webpack\@5.42.0: [#723](vercel/ncc#723) - Feat: update to webpack\@5.43.0: [#724](vercel/ncc#724) - Chore: bump set-getter from 0.1.0 to 0.1.1: [#719](vercel/ncc#719) - Fix: typo in readme: [#712](vercel/ncc#712) ##### Credits Huge thanks to [@rethab](https://github.com/rethab) and [@guybedford](https://github.com/guybedford) for helping! ### [`v0.28.6`](https://github.com/vercel/ncc/releases/tag/0.28.6) [Compare Source](vercel/ncc@0.28.5...0.28.6) ##### Patches - Fix: Update to webpack\@5.36.2: [#707](vercel/ncc#707) - Fix: Update ts-loader to fix webpack warning: [#710](vercel/ncc#710) - Deps: Bump hosted-git-info from 2.8.8 to 2.8.9: [#708](vercel/ncc#708) ##### Credits Huge thanks to [@adriencohen](https://github.com/adriencohen) and [@huozhi](https://github.com/huozhi) for helping! ### [`v0.28.5`](https://github.com/vercel/ncc/releases/tag/0.28.5) [Compare Source](vercel/ncc@0.28.4...0.28.5) ##### Patches - Fix: handle terser error: [#703](vercel/ncc#703) - Fix: treat compilation.errors as a set: [#705](vercel/ncc#705) - Fix: unify `target` arg description, add `transpile-only` arg to readme: [#702](vercel/ncc#702) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) and [@Simek](https://github.com/Simek) for helping! ### [`v0.28.4`](https://github.com/vercel/ncc/releases/tag/0.28.4) [Compare Source](vercel/ncc@0.28.3...0.28.4) ##### Patches - Fix: Adjust caching to use hashes: [#698](vercel/ncc#698) - Fix: support top-level await: [#700](vercel/ncc#700) - Fix: publish should build without cache: [#701](vercel/ncc#701) - Chore: redis from 2.8.0 to 3.1.1: [#699](vercel/ncc#699) - Chore: Bump ssri from 6.0.1 to 6.0.2: [#695](vercel/ncc#695) - Chore: rename master to main: [#694](vercel/ncc#694) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) for helping! ### [`v0.28.3`](https://github.com/vercel/ncc/releases/tag/0.28.3) [Compare Source](vercel/ncc@0.28.2...0.28.3) ##### Patches - Fix: lock license plugin version: [#692](vercel/ncc#692) ##### Credits Huge thanks to [@huozhi](https://github.com/huozhi) for helping! ### [`v0.28.2`](https://github.com/vercel/ncc/releases/tag/0.28.2) [Compare Source](vercel/ncc@0.28.1...0.28.2) ##### Patches - Fix: unknown compiler option `incremental`: [#685](vercel/ncc#685) - Fix: replace .npmignore with "files" prop: [#688](vercel/ncc#688) ##### Credits Huge thanks to [@Songkeys](https://github.com/Songkeys) for helping! ### [`v0.28.1`](https://github.com/vercel/ncc/releases/tag/0.28.1) [Compare Source](vercel/ncc@0.28.0...0.28.1) ##### Patches - Fix: Rebuild bundle to fix [#684](vercel/ncc#684) - Deps: Bump codecov to 3.8.1: [#683](vercel/ncc#683) ### [`v0.28.0`](https://github.com/vercel/ncc/releases/tag/0.28.0) [Compare Source](vercel/ncc@0.27.0...0.28.0) ##### Minor Changes - Feat: `exports` conditions semantics: [#665](vercel/ncc#665) - Feat: `imports` support, webpack upgrade: [#672](vercel/ncc#672) - Feat: Support Regexp externals: [#654](vercel/ncc#654) - Fix: TS interop test and fix: [#671](vercel/ncc#671) - Fix: Upgrade local TS: [#674](vercel/ncc#674) - Chore: Interop test case: [#667](vercel/ncc#667) - Chore: add console output when minifying fails: [#648](vercel/ncc#648) - Chore: Add Node.js 14 to CI: [#659](vercel/ncc#659) - Docs: Fix out \[file] → out \[dir]: [#675](vercel/ncc#675) - Deps: Update to webpack\@5.30.0: [#681](vercel/ncc#681) - Deps: Update to webpack\@5.26.3: [#664](vercel/ncc#664) - Deps: Update to webpack\@5.24.4: [#658](vercel/ncc#658) - Deps: Update to webpack-asset-relocator-loader\@1.3.0: [#682](vercel/ncc#682) - Deps: Upgrade to webpack-asset-relocator-loader\@1.2.4: [#673](vercel/ncc#673) - Deps: Update to webpack-asset-relocator\@1.2.3: [#662](vercel/ncc#662) - Deps: Upgrade to terser\@5.6.1: [#669](vercel/ncc#669) - Deps: Bump socket.io from 2.2.0 to 2.4.0: [#645](vercel/ncc#645) - Deps: Bump pug from 2.0.3 to 3.0.1: [#656](vercel/ncc#656) - Deps: Bump elliptic from 6.5.3 to 6.5.4: [#657](vercel/ncc#657) - Deps: Bump msgpack5 from 4.2.1 to 4.5.1: [#660](vercel/ncc#660) - Deps: Bump y18n from 3.2.1 to 3.2.2: [#678](vercel/ncc#678) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford), [@Songkeys](https://github.com/Songkeys), [@adriencohen](https://github.com/adriencohen), and [@huozhi](https://github.com/huozhi) for helping! ### [`v0.27.0`](https://github.com/vercel/ncc/releases/tag/0.27.0) [Compare Source](vercel/ncc@0.26.2...0.27.0) ##### Changes - Feat: support customEmit ncc option: [#634](vercel/ncc#634) - Fix: correct declaration output dir: [#627](vercel/ncc#627) - Update to webpack-asset-relocator\@1.2.0: [#640](vercel/ncc#640) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) and [@zeroooooooo](https://github.com/zeroooooooo) for helping! ### [`v0.26.2`](https://github.com/vercel/ncc/releases/tag/0.26.2) [Compare Source](vercel/ncc@0.26.1...0.26.2) ##### Patches - Enable minification for sourcemap-register.js: [#631](vercel/ncc#631) - Avoid **webpack\_require** conflicts: [#633](vercel/ncc#633) - Bump axios from 0.18.1 to 0.21.1: [#636](vercel/ncc#636) - Fix: skip typechecking on sub-builds: [#637](vercel/ncc#637) ##### Credits Huge thanks to [@xom9ikk](https://github.com/xom9ikk) and [@guybedford](https://github.com/guybedford) for helping! ### [`v0.26.1`](https://github.com/vercel/ncc/releases/tag/0.26.1) [Compare Source](vercel/ncc@0.26.0...0.26.1) ##### Patches - Ensure separate asset compilation states in subbuilds: [#630](vercel/ncc#630) ##### Credits Huge thanks to [@guybedford](https://github.com/guybedford) for helping! ### [`v0.26.0`](https://github.com/vercel/ncc/releases/tag/0.26.0) [Compare Source](vercel/ncc@0.25.1...0.26.0) ##### Changes - Asset subbundle builds: [#625](vercel/ncc#625) - Bump ini from 1.3.5 to 1.3.7: [#624](vercel/ncc#624) - Update example with missing TypeScript dependency: [#623](vercel/ncc#623) - Update readme with missing TS and ES options: [#615](vercel/ncc#615) ##### Credits Huge thanks to [@restuwahyu13](https://github.com/restuwahyu13) and [@guybedford](https://github.com/guybedford) for helping! ### [`v0.25.1`](https://github.com/vercel/ncc/releases/tag/0.25.1) [Compare Source](vercel/ncc@0.25.0...0.25.1) ##### Changes - Allow passing `target`: [#614](vercel/ncc#614) ##### Credits Huge thanks to [@ijjk](https://github.com/ijjk) for helping! ### [`v0.25.0`](https://github.com/vercel/ncc/releases/tag/0.25.0) [Compare Source](vercel/ncc@0.24.1...0.25.0) ##### Changes - Bump `webpack` from `5.0.0-beta.28` to `5.2.0`: [#602](vercel/ncc#602) - Bump `npm-user-validate` from `1.0.0` to `1.0.1`: [#604](vercel/ncc#604) - Bump `object-path` from `0.11.4` to `0.11.5`: [#607](vercel/ncc#607) - Fix `--quiet` flag on ts build: [#605](vercel/ncc#605) - Add integration test for `@slack/web-api`: [#591](vercel/ncc#591) ##### Credits Huge thanks to [@huozhi](https://github.com/huozhi) and [@ataylorme](https://github.com/ataylorme) for helping! </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  --------- Co-authored-by: Nicolas <[email protected]> Reviewed-on: https://gitea.com/gitea/runner/pulls/881 Reviewed-by: Nicolas <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

disable ts incremental option

f2872a5

huozhi requested review from Timer and styfle as code owners March 23, 2021 15:56

upgrade ts, ts-loader

d96e03f

styfle reviewed Mar 23, 2021

View reviewed changes

huozhi marked this pull request as draft March 24, 2021 02:20

update local ts bundle

b8f3990

huozhi added 3 commits March 24, 2021 23:47

soft link to local ts

97acf3b

bump ts version

30a0d94

fix coverage

4f7a868

huozhi marked this pull request as ready for review March 24, 2021 16:26

huozhi requested a review from styfle March 24, 2021 16:26

styfle reviewed Mar 24, 2021

View reviewed changes

Comment thread yarn.lock Outdated

styfle reviewed Mar 24, 2021

View reviewed changes

styfle changed the title ~~disable ts incremental option~~ fix: disable ts incremental option Mar 24, 2021

styfle changed the title ~~fix: disable ts incremental option~~ fix: disable TS incremental option Mar 24, 2021

huozhi commented Mar 25, 2021

View reviewed changes

Comment thread yarn.lock Outdated

correct yarn lock registry

490c934

styfle approved these changes Mar 30, 2021

View reviewed changes

stick to ts 3.x and update test for leveraging local ts built

8bf3c5c

huozhi changed the title ~~fix: disable TS incremental option~~ enhance: upgrade local ts Apr 2, 2021

huozhi requested a review from styfle April 2, 2021 10:58

guybedford approved these changes Apr 2, 2021

View reviewed changes

styfle reviewed Apr 4, 2021

View reviewed changes

Comment thread test/index.test.js Outdated

merge env

9678c2b

Co-authored-by: Steven <[email protected]>

styfle enabled auto-merge (squash) April 5, 2021 13:27

styfle approved these changes Apr 5, 2021

View reviewed changes

Merge branch 'master' into disable-incremental

c82a369

styfle added the automerge Automatically merge PR once checks pass label Apr 5, 2021

styfle merged commit 6f4714d into vercel:master Apr 5, 2021

huozhi deleted the disable-incremental branch April 5, 2021 14:45

songkeys mentioned this pull request Apr 7, 2021

fix: unknown compiler option 'incremental' #685

Merged

huozhi mentioned this pull request Apr 13, 2021

fix: lock license plugin version #692

Merged

Conversation

huozhi commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

huozhi commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guybedford commented Mar 24, 2021

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

guybedford commented Mar 24, 2021

Uh oh!

styfle commented Mar 24, 2021

Uh oh!

guybedford commented Mar 24, 2021

Uh oh!

huozhi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-io commented Mar 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

styfle commented Mar 30, 2021

Uh oh!

huozhi commented Apr 1, 2021

Uh oh!

guybedford commented Apr 1, 2021

Uh oh!

huozhi commented Apr 2, 2021

Uh oh!

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huozhi commented Mar 23, 2021 •

edited

Loading

huozhi commented Mar 24, 2021 •

edited

Loading

codecov-io commented Mar 28, 2021 •

edited

Loading