New analysis updates#378
Conversation
|
In addition - package resolutions are attempted for resolution at runtime before throwing a not found error. |
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 74.41% 73.29% -1.12%
==========================================
Files 12 14 +2
Lines 387 397 +10
==========================================
+ Hits 288 291 +3
- Misses 99 106 +7
Continue to review full report at Codecov.
|
If these warnings are decreasing performance, we should remove them. Like you mentioned before: if the module require is tried at runtime and not found, then there will be an error instead. I think this error is pretty self-explanatory. |
4bce4b2 to
44bf045
Compare
1783808 to
698583c
Compare
|
Can all those issues be closed now? |
|
Yes, all those issues can be closed! |
This updates to [email protected], which includes resolutions for the following ncc bugs:
@ffmpeg-installer/ffmpegpackage #376 (integration test included)__dirnamewhen importing files dynamically #216__dirnamewhen importing files dynamically #216__dirnamewildcards #297The full description of the analysis changes is in vercel/webpack-asset-relocator-loader#30.
In ncc itself we also change not found errors into runtime errors and remove the external warnings for not-found requires.