feat: support TypeScript 6 transpile builds#1316
Merged
styfle merged 1 commit intovercel:mainfrom Apr 28, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
54 tasks
Update ts-loader to include the rootDir handling fix needed by TypeScript 6. Made-with: Cursor
roryabraham
force-pushed
the
fix-typescript-6-rootdir-build
branch
from
4986753 to
f8f55f9
Compare
styfle
changed the title
styfle
approved these changes
Apr 28, 2026
Member
styfle
left a comment
styfle
left a comment
There was a problem hiding this comment.
Thanks! I marked as feat since this is enabling new features of typescript@6.
Ideally this would have a test also to confirm the new features work.
Contributor
Author
|
@styfle thanks for reviewing! For what it's worth, I tested this via patch-package for the bundling of our JS GitHub Actions over at Expensify/App#89061 By the way, it looks like the npm publish for 0.39 failed with a 403 error. Seems unrelated to these changes. I see ncc hasn't been published for ~7 months - perhaps it's using a classic npm token that's been revoked. |
Member
|
Thanks, I'll see if IT can generate a new token so we can publish again 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
ts-loaderto9.5.7so ncc's bundled TypeScript loader preserves configuredrootDirduringtranspileModulebuilds.This fixes TypeScript 6
TS5011failures like:ts-loaderfixed this upstream in TypeStrong/ts-loader#1679.Verification
yarn build