Set encoding to utf-8 for JSON response#302
Merged
leo merged 5 commits intovercel:masterfrom Sep 12, 2017
floatdrop:default-utf8-charset
Merged
Set encoding to utf-8 for JSON response#302leo merged 5 commits intovercel:masterfrom floatdrop:default-utf8-charset
leo merged 5 commits intovercel:masterfrom
floatdrop:default-utf8-charset
Conversation
Contributor
Author
|
@leo bump. |
ssut
reviewed
Sep 12, 2017
lib/index.js
Outdated
|
|
||
| if (!res.getHeader('Content-Type')) { | ||
| res.setHeader('Content-Type', 'application/json') | ||
| res.setHeader('Content-Type', 'application/json; encoding=utf-8') |
There was a problem hiding this comment.
I think this should be charset=utf-8 instead of encoding=utf-8 by RFC2068 and the official w3 article.
Contributor
Author
There was a problem hiding this comment.
Oh, right! Thanks!
Contributor
|
@floatdrop Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #301