Skip to content

Commit b471e97

Browse files
committed
address review
1 parent b16a7f7 commit b471e97

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

packages/cookies/src/serialize.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,20 @@ export interface CookieListItem
2020
export type Cookie = CookieListItem &
2121
Pick<CookieSerializeOptions, 'httpOnly' | 'maxAge' | 'priority'>
2222

23-
export function serialize(c: Cookie): string {
23+
export function serialize(cookie: Cookie): string {
2424
const attrs = [
25-
c.path ? `Path=${c.path}` : '',
26-
c.expires ? `Expires=${c.expires.toUTCString()}` : '',
27-
c.maxAge ? `Max-Age=${c.maxAge}` : '',
28-
c.domain ? `Domain=${c.domain}` : '',
29-
c.secure ? 'Secure' : '',
30-
c.httpOnly ? 'HttpOnly' : '',
31-
c.sameSite ? `SameSite=${c.sameSite}` : '',
25+
cookie.path ? `Path=${cookie.path}` : '',
26+
cookie.expires ? `Expires=${cookie.expires.toUTCString()}` : '',
27+
cookie.maxAge ? `Max-Age=${cookie.maxAge}` : '',
28+
cookie.domain ? `Domain=${cookie.domain}` : '',
29+
cookie.secure ? 'Secure' : '',
30+
cookie.httpOnly ? 'HttpOnly' : '',
31+
cookie.sameSite ? `SameSite=${cookie.sameSite}` : '',
3232
].filter(Boolean)
3333

34-
return `${c.name}=${encodeURIComponent(c.value ?? '')}; ${attrs.join('; ')}`
34+
return `${cookie.name}=${encodeURIComponent(
35+
cookie.value ?? ''
36+
)}; ${attrs.join('; ')}`
3537
}
3638

3739
/**

0 commit comments

Comments
 (0)