Repository navigation
fix(openai-compatible): prevent redundant reasoningEffort field - #8392
Merged
gr2m merged 1 commit intoSep 2, 2025
Merged
Conversation
Contributor
Author
|
Hey @lgrammel could you take a look? I think this is a pretty quick win. Thanks :) |
…easoning_effort Fixes vercel#8372
jessevdp
force-pushed
the
fix-openai-compatible-duplicate-reasoning-effort
branch
from
September 2, 2025 07:12
4885c1f to
56236a7
Compare
Collaborator
|
Hey Jesse, thanks for the pull request, I'm having a look.
No need for extra pings, we do what we can 🙏🏼 Lars is out this week for a conference |
Contributor
Author
|
Sorry, my bad! Thanks for taking a look :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent redundant
reasoningEffortfield alongsidereasoning_effortin request body.Fixes #8372
Background
See #8372. Some OpenAI compatible backends (like LiteLLM proxying to Azure, which is what I can personally test) are tripping over the
reasoningEffortfield with errors like:Summary
I decided to NOT forward (spread) any of the "known"
openaiCompatibleProviderOptionsto avoid duplication. The idea is that these are already added to the correct part of the request body anyway. Why else would they be parsed out?Tasks
Documentation has been added / updated (for bug fixes / features)pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
—
Related Issues
Fixes #8372