Conversation
Updated filesToSignStr to use double quotes on Windows and single quotes on other platforms. This ensures file paths with spaces or special characters are handled correctly during code signing across different operating systems.
Refactored file path and argument handling for Linux code signing. Removed the double escape by previous commit File paths are now wrapped in single quotes, and a new EscapeForBash method ensures special characters in signing arguments are properly escaped for bash. Removed redundant manual escaping in RunSigningCommand, relying on earlier escaping for command safety.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #772 +/- ##
===========================================
- Coverage 42.76% 38.17% -4.59%
===========================================
Files 258 257 -1
Lines 19532 19450 -82
Branches 2122 2078 -44
===========================================
- Hits 8353 7426 -927
- Misses 10798 11698 +900
+ Partials 381 326 -55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #759
Closes #748