Conversation
Houzvicka
force-pushed
the
feature/splashScreenImprovmenets
branch
from
d6d106d to
4bdd5f4
Compare
|
This looks like a reasonable and well done change. Thanks very much for submitting. I'll do some testing! One nitpick would be: I feel like the CLI option should be more clear that it's related to the splash screen. e.g. |
|
@caesay I try to implement your suggestions :) You can check it in latest commit |
# Conflicts: # src/bins/Cargo.toml # src/bins/src/windows/splash.rs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #764 +/- ##
===========================================
+ Coverage 38.46% 41.69% +3.22%
===========================================
Files 257 258 +1
Lines 19535 19818 +283
Branches 2078 2124 +46
===========================================
+ Hits 7515 8263 +748
+ Misses 11696 11184 -512
- Partials 324 371 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
After migrating from Squirrel, I realized that Velopack has always had a background under the splash screen.
This PR fixes that by enabling true transparency, and also adds options to hide or change the color of the progress bar.
The changes to splash screen rendering for transparency also improve DPI handling. (#633 , #236 )