Conversation
Adds an explicit wxPython installation step for the `PythonWXPython` sample when building on macOS runners. This ensures the `libpng` dependency is met, preventing potential CI build failures caused by the missing library.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #754 +/- ##
===========================================
+ Coverage 40.91% 41.21% +0.29%
===========================================
Files 244 244
Lines 18385 18385
Branches 2049 2049
===========================================
+ Hits 7523 7578 +55
+ Misses 10504 10439 -65
- Partials 358 368 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PythonWXPythonsample build was encountering issues on macOS, specifically related to alibpngdependency withwxPython. This change addresses the problem by:wxPythondependency to version4.2.4in thepyproject.tomlfile.wxPythonusingpipin the GitHub Actions workflow for macOS builds. This ensureswxPythonis properly installed before other dependency management steps, preventing thelibpngdependency conflict.This resolves the previous build failures for the
PythonWXPythonsample on macOS.