Fix applying deltas with new directories#749
Merged
caesay merged 1 commit intovelopack:developfrom Feb 22, 2026
Merged
Conversation
Keboo
force-pushed
the
create-parent-dirs-for-new-files
branch
from
469c5af to
e048c9c
Compare
Keboo
approved these changes
Dec 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #749 +/- ##
===========================================
- Coverage 40.91% 39.43% -1.49%
===========================================
Files 244 244
Lines 18385 18386 +1
Branches 2049 2049
===========================================
- Hits 7523 7251 -272
- Misses 10504 10796 +292
+ Partials 358 339 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @Keboo @caesay is there anything we can do to get this moving? Btw the same logic exists in the C# implementation: velopack/src/vpk/Velopack.Packaging/Compression/DeltaPackage.cs Lines 167 to 168 in a2592d1 It was just missing in the rust implementation. |
Contributor
Author
|
Thanks! @caesay It's been a while since the last prerelease, any chance we could get a new one built? Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a delta with new files in a new directory, the updater currently fails with:
Error: Patch error: Delta error: No such file or directory (os error 2)Because the destination directory does not exist when copying the files.