-
-
Notifications
You must be signed in to change notification settings - Fork 111
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
The whole thread is here: https://discord.com/channels/767856501477343282/1438341041571889286
Effectively, even though all the checksums were verified, and the package was re-zipped successfully, the result was a corrupt archive which could not be opened.
Because there were no "errors" during delta, we then moved this package into it's final location, causing an update loop where "apply" kept failing, but there was nothing new to download to recover from this state.
We should fix this by:
- Replacing mtzip with something more robust (even if it's slower) to try and avoid corrupt zips from being created
- If "apply" fails due with a zip archive related error (e.g. not a "files in use" type of error) then we should delete the package from disk, to trigger a full update and avoid a stuck loop.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working