System.Xml.XmlException when release notes contain an ampersand #666
Description
OS
Win 11 24H2 26100.4061
Programming Language
dotnet 9.0
VPK Version
Velopack CLI 0.0.1251
Library Version
v 0.0.1251
What happened?
Hello :)
I was adding a change log to the package. But unfortunately, I get the exception about EntityName. Without --releaseNotes and it's value, everything works like a charm. Do you have any idea how to solve it?
My command is
01:02:23 [INF] > "C:\Program Files\dotnet\dotnet.exe" C:\Users\dalec\.nuget\packages\vpk\0.0.1251\tools\net9.0\any\vpk.dll vpk [win] pack -u ConsoleTemplate -v 1.4.0-37-doda--poprawnego-changelogadevelop.1+51 -p C:\Users\dalec\source\repos\ZtrTemplates\output --icon C:\Users\dalec\source\repos\ZtrTemplates\templates\console\applogo.ico --outputDir C:\Users\dalec\source\repos\ZtrTemplates\Velopack\publish --runtime win-x64 --channel win-x64-alpha --delta none --releaseNotes C:\Users\dalec\source\repos\ZtrTemplates\.nuke\temp\release_notes.mdContent of release_notes.md file
featapp implement Velopack updates from GitHub & display release notes
featbuild enhance update configuration and GitHub release process
featbuild implement dynamic update configuration based on publish target
featbuild add dotnet format target
One time more
Try to fix vpk usage on build server
Change construction of parameters
Change construction of parameters
Change construction of parameters
Add Ubuntu to build app by default
refactorbuild consolidate on Velopack GitHub releases workflowRelevant log output
01:02:23 [INF] > "C:\Program Files\dotnet\dotnet.exe" C:\Users\dalec\.nuget\packages\vpk\0.0.1251\tools\net9.0\any\vpk.dll vpk [win] pack -u ConsoleTemplate -v 1.4.0-37-doda--poprawnego-changelogadevelop.1+51 -p C:\Users\dalec\source\repos\ZtrTemplates\output --icon C:\Users\dalec\source\repos\ZtrTemplates\templates\console\applogo.ico --outputDir C:\Users\dalec\source\repos\ZtrTemplates\Velopack\publish --runtime win-x64 --channel win-x64-alpha --delta none --releaseNotes C:\Users\dalec\source\repos\ZtrTemplates\.nuke\temp\release_notes.md
01:02:24 [DBG] [01:02:24 INF] Velopack CLI 0.0.1251, for distributing applications.
01:02:24 [DBG] [01:02:24 INF] Beginning to package Velopack release 1.4.0-37-doda--poprawnego-changelogadevelop.1+51.
01:02:24 [DBG] [01:02:24 INF] Releases Directory: C:\Users\dalec\source\repos\ZtrTemplates\Velopack\publish
01:02:24 [DBG] [01:02:24 INF] Starting: Pre-process steps
01:02:24 [DBG] [01:02:24 WRN] VelopackApp.Run() was found in method 'System.Void ConsoleTemplate.Program+<Main>d__0::MoveNext()', which does not look like your application's entry point. It is strongly recommended that you move this to the very beginning of your Main() method.
01:02:25 [DBG] [01:02:25 INF] Complete: Pre-process steps
01:02:25 [DBG] [01:02:25 INF] Starting: Code-sign application
01:02:25 [DBG] [01:02:25 WRN] No signing parameters provided, 223 file(s) will not be signed.
01:02:25 [DBG] [01:02:25 INF] Complete: Code-sign application
01:02:25 [DBG] [01:02:25 INF] Starting: Building portable package
01:02:25 [DBG] [01:02:25 INF] Starting: Building release 1.4.0-37-doda--poprawnego-changelogadevelop.1+51
01:02:28 [DBG] [01:02:28 INF] Complete: Building portable package
01:02:28 [DBG] [01:02:28 INF] Complete: Building release 1.4.0-37-doda--poprawnego-changelogadevelop.1+51
01:02:28 [DBG] [01:02:28 INF] Starting: Building setup package
01:02:28 [DBG] [01:02:28 FTL] An error occurred while parsing EntityName. Line 15, position 64.
01:02:28 [DBG] System.Xml.XmlException: An error occurred while parsing EntityName. Line 15, position 64.
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.Throw(Exception e)
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.Throw(String res, Int32 lineNo, Int32 linePos)
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.HandleEntityReference(Boolean isInAttributeValue, EntityExpandType expandType, Int32& charRefEndPos)
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.ParseText(Int32& startPos, Int32& endPos, Int32& outOrChars)
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.FinishPartialValue()
01:02:28 [DBG] at System.Xml.XmlTextReaderImpl.get_Value()
01:02:28 [DBG] at System.Xml.Linq.XContainer.ContentReader.ReadContentFrom(XContainer rootContainer, XmlReader r)
01:02:28 [DBG] at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
01:02:28 [DBG] at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
01:02:28 [DBG] at Velopack.NuGet.NugetUtil.LoadSafe(Stream input, Boolean ignoreWhiteSpace) in ./lib-csharp/NuGet/NugetUtil.cs:line 169
01:02:28 [DBG] at Velopack.NuGet.PackageManifest.ReadManifest(Stream manifestStream) in ./lib-csharp/NuGet/PackageManifest.cs:line 61
01:02:28 [DBG] at Velopack.NuGet.ZipPackage..ctor(String filePath, Boolean loadUpdateExe) in ./lib-csharp/NuGet/ZipPackage.cs:line 23
01:02:28 [DBG] at Velopack.Packaging.Windows.Commands.WindowsPackCommandRunner.CreateSetupPackage(Action`1 progress, String releasePkg, String packDir, String targetSetupExe, Func`3 createAsset) in ./vpk/Velopack.Packaging.Windows/Commands/WindowsPackCommandRunner.cs:line 202
01:02:28 [DBG] at Velopack.Packaging.PackageBuilder`1.<>c__DisplayClass26_1.<<Run>b__5>d.MoveNext() in ./vpk/Velopack.Packaging/PackageBuilder.cs:line 157
01:02:28 [DBG] --- End of stack trace from previous location ---
01:02:28 [DBG] at Velopack.Vpk.Logging.BasicConsole.Progress.RunTask(String name, Func`2 fn) in ./vpk/Velopack.Vpk/Logging/BasicConsole.cs:line 60
01:02:28 [DBG] at Velopack.Packaging.PackageBuilder`1.<>c__DisplayClass26_0.<<Run>b__0>d.MoveNext() in ./vpk/Velopack.Packaging/PackageBuilder.cs:line 177
01:02:28 [DBG] --- End of stack trace from previous location ---
01:02:28 [DBG] at Velopack.Vpk.Logging.BasicConsole.ExecuteProgressAsync(Func`2 action) in ./vpk/Velopack.Vpk/Logging/BasicConsole.cs:line 26
01:02:28 [DBG] at Velopack.Packaging.PackageBuilder`1.Run(T options) in ./vpk/Velopack.Packaging/PackageBuilder.cs:line 109
01:02:28 [DBG] at Velopack.Vpk.ProgramCommandExtensions.<>c__DisplayClass3_0`2.<<Add>b__0>d.MoveNext() in ./vpk/Velopack.Vpk/Program.cs:line 272