Repository navigation
Backport to 1.14: Only set PutObject Tagging when tags are configured - #309
Merged
Merged
Conversation
kaovilai
approved these changes
Jun 26, 2026
PutObject always passed Tagging: aws.String(o.tagging), even when the BSL config's `tagging` field is the default empty string. With newer aws-sdk-go-v2 (pulled in via the Go 1.25 bump for v1.14.x), an empty *string still serializes an empty `x-amz-tagging:` HTTP header, which S3-compatible backends reject — Backblaze B2 returns HTTP 400 "InvalidArgument: Unsupported header 'x-amz-tagging'" on the final velero-backup.json write, leaving PVB data orphaned in the bucket without an index file. Older aws-sdk-go-v2 (in v1.13.1) omitted the header when the value was empty, masking the bug. Extract the PutObjectInput construction into a buildPutObjectInput helper, and guard the Tagging assignment with `if o.tagging != ""` so empty configs send no Tagging field at all. This matches the existing pattern for `checksumAlgorithm` / `kmsKeyID` / `customerKeyEncryptionFile` already used in the same function. Add a table-driven TestBuildPutObjectInput regression test covering: - empty config produces no Tagging / no SSE / no checksum - non-empty tagging is set verbatim - checksumAlgorithm sets ChecksumAlgorithm - kmsKeyID switches SSE to aws:kms with the key ID - sseCustomerKey populates SSE-C fields - serverSideEncryption sets ServerSideEncryption Fixes silent breakage of Velero backups on Backblaze B2 (and likely other S3-compatible backends that don't tolerate the empty header) when using velero-plugin-for-aws v1.14.x. Signed-off-by: Dillon Browne <[email protected]> (cherry picked from commit 8dbd6b8) Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Joeavaikath
approved these changes
Jun 26, 2026
sseago
approved these changes
Jun 26, 2026
Author
1 task
scareyo
pushed a commit
to scareyo/homelab
that referenced
this pull request
Oct 24, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [velero/velero-plugin-for-aws](https://github.com/vmware-tanzu/velero-plugin-for-aws) | image | minor | `v1.12.0` → `v1.14.4` | --- ### Release Notes <details> <summary>vmware-tanzu/velero-plugin-for-aws (velero/velero-plugin-for-aws)</summary> ### [`v1.14.4`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.14.4) [Compare Source](velero-io/velero-plugin-for-aws@v1.14.3...v1.14.4) #### All changes - Fix CVEs for 1.14.4. ([#​336](velero-io/velero-plugin-for-aws#336), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.14.3`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.14.3) [Compare Source](velero-io/velero-plugin-for-aws@v1.14.2...v1.14.3) #### All changes - Bump golang version and google.golang.org/grpc version. ([#​333](velero-io/velero-plugin-for-aws#333), [@​blackpiglet](https://github.com/blackpiglet)) - Bump dependencies and Go version to fix CVEs ([#​329](velero-io/velero-plugin-for-aws#329), [@​blackpiglet](https://github.com/blackpiglet)) - Fix prevent amz-checksum encapsulation when checksumAlgorithm="" ([#​313](velero-io/velero-plugin-for-aws#313), [@​kaovilai](https://github.com/kaovilai)) - Fix SSE-C signed URLs ([#​310](velero-io/velero-plugin-for-aws#310), [@​Minding000](https://github.com/Minding000)) - Only set PutObject Tagging when tags are configured ([#​309](velero-io/velero-plugin-for-aws#309), [@​cleverer](https://github.com/cleverer)) ### [`v1.14.2`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.14.2) [Compare Source](velero-io/velero-plugin-for-aws@v1.14.1...v1.14.2) #### All changes - Backport PR [#​276](velero-io/velero-plugin-for-aws#276) support for specifying KMS key for EBS volume restoration ([#​306](velero-io/velero-plugin-for-aws#306), [@​TheKingMarco](https://github.com/TheKingMarco)) - Bump dependencies to fix CVEs for v1.14.2 ([#​305](velero-io/velero-plugin-for-aws#305), [@​blackpiglet](https://github.com/blackpiglet)) - \[1.14] Bump dependancies version ([#​302](velero-io/velero-plugin-for-aws#302), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.14.1`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.14.1) [Compare Source](velero-io/velero-plugin-for-aws@v1.14.0...v1.14.1) #### All changes - Bump Velero to v1.18.1-rc.1 ([#​292](velero-io/velero-plugin-for-aws#292), [@​blackpiglet](https://github.com/blackpiglet)) - Bump Golang to 1.25.9 and go.mod to fix CVEs. ([#​291](velero-io/velero-plugin-for-aws#291), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.14.0`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.14.0) [Compare Source](velero-io/velero-plugin-for-aws@v1.13.2...v1.14.0) #### All changes - Bump Golang to 1.25.7 for v1.14.0-rc.1 ([#​282](velero-io/velero-plugin-for-aws#282), [@​blackpiglet](https://github.com/blackpiglet)) - Bump golang from 1.24 to 1.25 ([#​281](velero-io/velero-plugin-for-aws#281), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.13.2`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.13.2) [Compare Source](velero-io/velero-plugin-for-aws@v1.13.1...v1.13.2) #### All changes - Bump Golang to 1.24.11 ([#​277](velero-io/velero-plugin-for-aws#277), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.13.1`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.13.1) [Compare Source](velero-io/velero-plugin-for-aws@v1.13.0...v1.13.1) #### All changes - Bump Golang to 1.24.9 for v1.13.1 ([#​275](velero-io/velero-plugin-for-aws#275), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.13.0`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.13.0) [Compare Source](velero-io/velero-plugin-for-aws@v1.12.2...v1.13.0) #### All changes - Remove GCR Update some action versions ([#​260](velero-io/velero-plugin-for-aws#260), [@​blackpiglet](https://github.com/blackpiglet)) - Add secret support for SSE-C with customer-provided keys in Velero AWS plugin ([@​261](https://github.com/261), [@​kaovilai](https://github.com/kaovilai)) - AWS plugin README lacks entries for velero 1.16 and AWS plugin 1.12 ([@​262](https://github.com/262), [@​hu-keyu](https://github.com/hu-keyu)) ### [`v1.12.2`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.12.2) [Compare Source](velero-io/velero-plugin-for-aws@v1.12.1...v1.12.2) #### What's Changed - Bump golang to 1.23.10 to fix CVEs. ([#​264](velero-io/velero-plugin-for-aws#264), [@​theadarshsaxena](https://github.com/theadarshsaxena)) - Bump Golang version to v1.23.11 to align with Velero v1.16.2. ([#​266](velero-io/velero-plugin-for-aws#266), [@​blackpiglet](https://github.com/blackpiglet)) ### [`v1.12.1`](https://github.com/velero-io/velero-plugin-for-aws/releases/tag/v1.12.1) [Compare Source](velero-io/velero-plugin-for-aws@v1.12.0...v1.12.1) #### What's Changed - Remove GCR. Update some action versions. ([#​259](velero-io/velero-plugin-for-aws#259), [@​blackpiglet](https://github.com/blackpiglet)) - Bump Golang and golang.org/x/net to fix CVEs. ([#​257](velero-io/velero-plugin-for-aws#257), [@​blackpiglet](https://github.com/blackpiglet)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMDQuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjEwNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://scarey.dev/scarey/homelab/pulls/41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #299 to Release 1.14