refactor: Centralize Vega project versioning#3720
Merged
dangotbanned merged 17 commits intomainfrom Jan 6, 2025
Merged
Conversation
- Defines `[tool.altair.vega]` in `pyproject.toml` - Adds tooling to propagate these versions throughout `altair`
dangotbanned
changed the title
vega project versioningVega project versioning
Need more info on `vegafusion`, @jonmmease
dangotbanned
commented
Dec 23, 2024
Single entrypoint for both `pyproject.toml` and `vl_convert` sourced versions
dangotbanned
requested review from
binste,
joelostblom,
jonmmease and
mattijn
and removed request for
jonmmease
dangotbanned
commented
Jan 1, 2025
…onvert-python` Reduces duplication, noted in #3720 (comment)
Member
Author
|
I'm gonna merge this and shift focus towards (#3723) which mainly needs to touch the same docs to finish off. When anyone is available again, please don't hesitate to reach out if you have any issues/suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to simplify version bumps of projects we depend on within the https://github.com/vega org.
The new process I'm proposing is documented in https://github.com/vega/altair/blob/7e0510854424235fc4f5a4818198c4ec464b20ab/NOTES_FOR_MAINTAINERS.md.
In short, we bump versions in
pyproject.tomland they propagate to everywhere they were previously manually maintained:altair/pyproject.toml
Lines 103 to 107 in 0c3c220
Note
Since resolving (#3720 (comment)),
vl-convert-pythonandvegafusionversions are sourced directly from[project.optional-dependencies].The new module https://github.com/vega/altair/blob/5aec51ef8eaf345936436abddd903ea87b86b968/tools/versioning.py handles said propagation.
Motivation
Vega-Lite
I think it was unintentional, but we missed a
vega-litebump in https://github.com/vega/altair/releases/tag/v5.5.0.We're still on https://github.com/vega/vega-lite/releases/tag/v5.20.1 but we should be on https://github.com/vega/vega-lite/releases/tag/v5.21.0 and now the latest is https://github.com/vega/vega-lite/releases/tag/v5.23.0
Additionally, these appear to be out-of-sync?
vl-convert
altair/pyproject.toml
Lines 56 to 58 in 1208c5d
altair/altair/utils/_importers.py
Lines 47 to 48 in 1208c5d
VegaFusion
altair/pyproject.toml
Line 66 in 1208c5d
altair/altair/utils/_importers.py
Lines 12 to 13 in 1208c5d
Future
I'm planning to pin
vega-datasetsfor (#3631).There are also likely to be a lot of version changes coming up as a result of (vega/vega#3990).
IMO having a single, highly visible place to update will make this process hopefully painless for us
Tasks
tomllibwhensys.version_info < (3, 11)RELEASING.md(dc0215c)NOTES_FOR_MAINTAINERS.md