Skip to content

feat: Support datetime.(date|datetime) in Expression(s)#3654

Merged
dangotbanned merged 8 commits intomainfrom
support-datetime-expr
Oct 30, 2024
Merged

feat: Support datetime.(date|datetime) in Expression(s)#3654
dangotbanned merged 8 commits intomainfrom
support-datetime-expr

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Oct 22, 2024 •
edited
Loading

Closes #3652

Example

import datetime as dt

import altair as alt
from vega_datasets import data

base = (
    alt.Chart(data.stocks.url)
    .mark_line()
    .encode(x="date:T", y="price:Q", color="symbol:N")
)

predicate = alt.datum["date"] <= dt.date(2005, 1, 1)

chart = (
    base.transform_filter(predicate) | base.transform_filter(~predicate)
).resolve_scale(y="shared")
chart

image

This was referenced Oct 25, 2024
Merged
Merged
@dangotbanned dangotbanned marked this pull request as ready for review October 30, 2024 09:31
jonmmease
jonmmease approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @dangotbanned, I really like the emphasis on improving the expression language API

@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Oct 30, 2024

This looks great @dangotbanned, I really like the emphasis on improving the expression language API

Thanks @jonmmease, appreciate the review

@dangotbanned dangotbanned merged commit 64c1e09 into main Oct 30, 2024
@dangotbanned dangotbanned deleted the support-datetime-expr branch October 30, 2024 13:12
@dangotbanned dangotbanned mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonmmease jonmmease jonmmease approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support datetime.(date|datetime) in Expression(s)

2 participants

@dangotbanned @jonmmease