Conversation
MarcoGorelli
force-pushed
the
delay-materialisation
branch
from
b732650 to
adc599a
Compare
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
delay-materialisation
branch
from
adc599a to
3a1c5b3
Compare
jonmmease
approved these changes
Sep 3, 2024
Contributor
jonmmease
left a comment
jonmmease
left a comment
There was a problem hiding this comment.
Thanks @MarcoGorelli, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In #3452 (review), @jonmmease pointed out that
I'd originally done that in the linked PR, but then in a subsequent refactor (in the later commit from the same PR) I must have accidentally regressed it, because currently,
arrow_table_from_dfi_dataframedoes get called, even with the vegafusion transformerThis PR fixes it, and adds a test to ensure this doesn't happen again
I noticed this whilst looking into supporting DuckDB, which is now also supported (for now, it requires PyArrow, as it goes down the same path in Altair that Ibis does, but we're aiming to get DuckDB supported here with zero extra dependencies - it's going to take some more work, but we're not that far off):