docs: Split interactive docs section into subpages#3561
Merged
joelostblom merged 12 commits intomainfrom Aug 31, 2024
Merged
Conversation
To make it easier to navigate instead of having one giant page.
The parts about performance and JupyterChart are under the Large Datasets section, so it seems natural that the part about interactivity would go together with the other interactive parts of the library.
I think this looks more pleasing as content without a right-side ToC stretches wider across the page.
joelostblom
commented
Aug 27, 2024
Member
|
FYI I was about to try building the docs, but needed this merged #3560 vl_convert stubs untracked
|
Member
|
sphinx shouting at me |
dangotbanned
requested changes
Aug 31, 2024
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Overall this makes for a much easier read thanks @joelostblom!
I was already on-board with the idea, so probably best to have approval from another maintainer.
index.rst is the only page I think needs revisiting, feel free to dismiss the suggestions
binste
approved these changes
Aug 31, 2024
Contributor
binste
left a comment
binste
left a comment
There was a problem hiding this comment.
I haven't read through all changes but I'm also all onboard splitting the interactive docs! Looks much better :) Thanks!
Co-authored-by: Dan Redding <[email protected]>
dangotbanned
approved these changes
Aug 31, 2024
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Looking much better thanks again @joelostblom
I'll approve this now.
You can drop the concepts suggestion if it doesn't seem right, but please commit the spellcheck one
Co-authored-by: Dan Redding <[email protected]>
Contributor
Author
|
Thank you! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3500 with @dangotbanned
New look:
