fix: Pass native dataframe to data transformers#3550
Merged
dangotbanned merged 4 commits intovega:mainfrom Aug 21, 2024
Merged
Conversation
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
csv-data-transformer
branch
2 times, most recently
from
220abd3 to
1eac049
Compare
MarcoGorelli
commented
Aug 21, 2024
MarcoGorelli
commented
Aug 21, 2024
MarcoGorelli
force-pushed
the
csv-data-transformer
branch
from
1eac049 to
8618928
Compare
MarcoGorelli
commented
Aug 21, 2024
MarcoGorelli
changed the title
dangotbanned
approved these changes
Aug 21, 2024
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
The comments I've pulled out are minor things, overall looks good to me.
Thanks @MarcoGorelli for putting this together so quickly
This was referenced Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3549
Also addresses the issue brought up in marimo-team/marimo#2006