Repository navigation
fix(codex): send client identity headers for GPT-5.6 - #2647
Conversation
JiehoonKwak
changed the title
benfrank241
left a comment
benfrank241
left a comment
There was a problem hiding this comment.
lgtm — reproduced the root cause: on main the codex provider sends a browser User-Agent: Mozilla/5.0… and no originator header, so newer models gated on the first-party client identity (luna) 404. running these header tests against pristine main fails with KeyError: 'originator'; on this branch they pass with originator: codex_cli_rs + codex_cli_rs/0.0.0 (Hindsight).
nice touches: DRY'd the duplicated header dicts into _build_request_headers(), and the UA is honest — neutral 0.0.0 + (Hindsight) rather than impersonating a real codex release. tests cover call, call_with_tools, and identity persistence across an oauth refresh; docs + skill mirror updated in sync. 27 pass locally.
approving + kicked off CI.
Summary
gpt-5.6-lunaselection without changing the default modelThe production change is confined to
codex_llm.py. The remaining files add regression coverage and update one documentation example plus its generated mirror.Fixes #2643.
Testing
npm run build --workspace=hindsight-docsgpt-5.4-minipassed plain text, strict structured output, and tool callingFull local suite: 3,795 passed; 7 failures and 7 errors require unavailable external credentials/services or test fixtures and are unrelated to this patch.