fix(dev): flush and sync files in file source tests#24243
Merged
thomasqueirozb merged 7 commits intomasterfrom Nov 14, 2025
Merged
fix(dev): flush and sync files in file source tests#24243thomasqueirozb merged 7 commits intomasterfrom
thomasqueirozb merged 7 commits intomasterfrom
Conversation
github-actions
Bot
added
the
domain: sources
thomasqueirozb
commented
Nov 14, 2025
pront
approved these changes
Nov 14, 2025
Member
pront
left a comment
pront
left a comment
There was a problem hiding this comment.
Nice fix. I see the pattern in many places:
file.flush().unwrap();
sleep_500_millis().await;
Could we remove some of these arbitrary sleeps?
You can test this by running cargo test -- --test-threads=8 repeatedly.
If it's too involved we can go ahead with this PR as is and follow-up in a separate PR.
…sition_server_restart_no_acknowledge on non-linux
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We should flush/sync instead of sleeping to ensure that files are written to disk properly. Sleeping is just hoping the OS will do our job for us
Vector configuration
NA
How did you test this PR?
cargo test -- sources::file::Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
file_start_position_server_restart_acknowledgedis flakey on non-Linux #7988Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.