Repository navigation
Preserve input order when loading RAG results - #162
Merged
Merged
Conversation
ofermend
requested review from
vish119
and
a balanced review from Copilot
and removed request for
vish119
October 8, 2026 02:17
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused ordering change has targeted regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Preserves input query order when loading RAG results, addressing the loader’s contribution to ordering instability reported in #67.
Changes:
- Disables group-key sorting while retaining existing grouping behavior.
- Adds a regression test using non-lexicographically ordered query IDs.
| File | Description |
|---|---|
| tests/test_rag_results_loader.py | Adds input-order regression coverage. |
| open_rag_eval/rag_results_loader.py | Uses sort=False to preserve first-seen group order. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
vish119
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(query_id, query_run)order when loading RAG resultspandas.DataFrame.groupbysorts group keys by default. When query IDs are generated independently between runs, that sorting can change the relative order of queries in the evaluation output. Passingsort=Falsepreserves the stable input order without changing grouping or evaluation semantics.Closes #67.
Testing
pytest tests/test_rag_results_loader.py -qgit diff --check