chore(cross-app): add VeChain logomark favicon (light/dark adaptive)#624
Conversation
The generic delegator's /estimate/clauses endpoint simulates the user's raw clauses without the executeWithAuthorization wrapper and without the embedded-wallet typed-data signature, so it under-estimates gas (and for NFT-heavy clauses can revert outright in simulation). The returned transactionCost was then used to build the transfer clause that pays the delegator's deposit account, leaving it insufficient to cover the actual on-chain gas. The failure was masked by a catch-all that surfaced a misleading "no gas tokens have sufficient balance" error even when the wallet had ample balance. Mirror VeWorld mobile's approach: trust the delegator only for the gas-token-per-gas rate (a market price independent of the gas amount), recompute the gas number locally with thor.gas.estimateGas (caller = smart account), add a fixed wrapper overhead per smart-account version plus a fixed fee-payer overhead per gas token, apply a 1.1 safety multiplier, then reapply the rate. New shared helper computeCorrectedGasTokenCost is used by the send path, the fee-estimation UI hook, and the all-tokens hook so they all agree. Also revert the homepage/playground feeDelegation override introduced in the cross-app PR. It set feeDelegation.delegatorUrl (dApp-sponsored mode) to the generic-delegator URL, which routed transactions through the dapp-kit fee-delegator path that POSTs to the bare base URL and 404s. With no override the kit's default getGenericDelegatorUrl() takes over and the request hits the correct /api/v1/sign/transaction/authorized/... endpoint. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
The cross-app-connect host shipped without a favicon — empty browser tab next to the "VeChain Connect" title. Wire the existing 300×300 brand assets in `public/brand/` as the favicon via Next.js metadata, with `prefers-color-scheme` media queries so the glyph variant stays legible against both light and dark browser tab UIs: - light tabs → `vechain-logomark-dark.png` (dark V on transparent) - dark tabs → `vechain-logomark-light.png` (white V on transparent) iOS Add-to-Home-Screen always gets the dark glyph — Apple ignores `prefers-color-scheme` on touch icons, and the dark V reads against the typical white home-screen tile. No new image files; reusing what's already in the public folder.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The cross-app-connect-check workflow runs `tsc --noEmit` before
`next build`, but Next.js only generates CSS Module type stubs
under `.next/types/` as part of a build. Without those stubs the
typecheck step fails with "Cannot find module './foo.module.css'
or its corresponding type declarations" on every styled component.
Add a small `src/types/css-modules.d.ts` ambient declaration so TS
resolves `*.module.css` imports without depending on Next's
build-time output. Same `{ readonly [key: string]: string }` shape
Next eventually generates; the runtime stays identical because
CSS Modules are still handled by the bundler.
|
Size Change: +26.1 kB (+0.3%) Total Size: 8.8 MB
ℹ️ View Unchanged
|
main shipped PR #624 which squashed our earlier generic-delegator fix together with the cross-app favicon. The three hook files (useGenericDelegator, useGenericDelegatorFeeEstimation, useEstimateAllTokens) on main are an older snapshot of this branch's work — superseded here by the hoist-estimate-out-of-loop + timeout + always-auto-inject refinements. Take 'ours' for those three files and pick up the new favicon assets (cross-app-connect/src/app/layout.tsx and css-modules.d.ts) from main. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Summary
The cross-app host had no favicon — browser tabs showed an empty default next to "VeChain Connect". Add the VeChain logomark, switching variants automatically based on the browser's
prefers-color-schemeso the glyph stays legible against both light and dark tab UIs.What changed
cross-app-connect/src/app/layout.tsx:No new image files — reusing the existing 300×300 PNGs already in
public/brand/.Built HTML
Test plan
https://connect.vechain.org/→ browser tab shows the VeChain V glyph.🤖 Generated with Claude Code