Skip to content

Commit 83aff07

Browse files
committed
proto: Drop LinuxRuntimeSpec (and work around 'linux' sensitivity)
This mirror's the previous commit's change for config.proto, so see that commit message for an explaination. The "linuxx" hack works around the "expected unqualified-id before numeric constant" breakage, so we can restore cpp/runtime_config.pb.h in the Makefile rule. Signed-off-by: W. Trevor King <[email protected]>
1 parent 9371318 commit 83aff07

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

proto/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ $(CPP_DIR)/%.pb.cc: %.proto
4545

4646
%_cpp: %.cc $(CPP_FILES)
4747
pkg-config --cflags protobuf # fails if protobuf is not installed
48-
c++ $< $(filter $(CPP_DIR)/config%.cc, $(CPP_FILES)) -o $@ $$(pkg-config --cflags --libs protobuf) -I $(CPP_DIR)
48+
c++ $< $(filter %.cc, $(CPP_FILES)) -o $@ $$(pkg-config --cflags --libs protobuf) -I $(CPP_DIR)
4949

5050
py: $(PY_FILES)
5151

proto/runtime_config.proto

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ message RuntimeSpec {
1010
repeated MountFieldEntry mounts = 1;
1111
// Hooks are the commands run at various lifecycle events of the container.
1212
Hooks hooks = 2;
13+
// LinuxRuntime is the Linux-specific, host-specific configuration.
14+
LinuxRuntime linuxx = 3;
1315
}
1416

1517
// MountFieldEntry is more backwards compatible protobuf associative map (than map<string, Mount>)
@@ -49,13 +51,6 @@ message Hooks {
4951
BEGIN Linux specific runtime
5052
*/
5153

52-
// LinuxRuntimeSpec is the full specification for linux containers.
53-
message LinuxRuntimeSpec {
54-
RuntimeSpec runtime_spec = 1;
55-
// LinuxRuntime is platform specific configuration for linux based containers.
56-
LinuxRuntime linux = 2;
57-
}
58-
5954
// LinuxRuntime hosts the Linux-only runtime information
6055
message LinuxRuntime {
6156
// UidMapping specifies user mappings for supporting user namespaces on linux.

0 commit comments

Comments
 (0)