Conversation
Owner
Author
|
@chipturner @kevin-vigor Just a heads up in case this gets in the way of any work you have ongoing. If there's no concern, I'll just merge tomorrow. |
Collaborator
|
The more platforms the better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last interesting platform for CI, unless someone comes forward with a weird requirement. Good luck getting CI for OpenSolaris 🤣
It uses a QEMU-based Docker image that I put together, but it still finishes in ~5 minutes, so good enough for me. Running it on Cirrus since it supports KVM, but it would probably not be that much slower on Github Actions.
Not many actual build fixes necessary, mostly just making sure we can get
symlink()on NetBSD.