Add The Ability to Quit a Running Server #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `running: Arc<AtomicBool>` parameter to `varlink::listen` that, when set to false, will shutdown the server.
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this pull request
Nov 15, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
|
What do you think about PR #27 ?? |
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this pull request
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this pull request
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this pull request
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
that referenced
this pull request
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes #26
Addresses #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
running: Arc<AtomicBool>parameter tovarlink::listenthat, when set to false, will shutdown the server.Addresses #25.
I'm open to any thoughts. This would be the second breaking API change in 48 hours. ;) Maybe it should be a different function so that we can keep the original
listen()function unchanged?Edit: Also the change needs documentation, but I'll wait until we figure out for sure how we want it before I add that.