fix smoketest Тесты_ПроверкаРеквизитовДокументовКомментарийОтветственный#816
Merged
Hidden character warning
The head ref may contain hidden characters: "fix-smoketest-\u0422\u0435\u0441\u0442\u044b_\u041f\u0440\u043e\u0432\u0435\u0440\u043a\u0430\u0420\u0435\u043a\u0432\u0438\u0437\u0438\u0442\u043e\u0432\u0414\u043e\u043a\u0443\u043c\u0435\u043d\u0442\u043e\u0432\u041a\u043e\u043c\u043c\u0435\u043d\u0442\u0430\u0440\u0438\u0439\u041e\u0442\u0432\u0435\u0442\u0441\u0442\u0432\u0435\u043d\u043d\u044b\u0439"
Conversation
Collaborator
|
@SidnevAV я вмержил твои предыдущие ПР, и теперь конфликты в файле tools/JSON/xUnitParams.json поправь их. |
artbear
requested changes
Nov 16, 2020
artbear
requested changes
Nov 30, 2020
artbear
left a comment
artbear
left a comment
Collaborator
There was a problem hiding this comment.
Предлагаю немного уточнить поведения для избежания ложных срабатываний.
Collaborator
There was a problem hiding this comment.
Предлагаю сразу пропускать тест, если у документа нет реквизита Комментарий
сейчас, если я правильно понимаю, будет выдана ошибка, что неверно.
не во всех документах есть этот реквизит.
Collaborator
There was a problem hiding this comment.
аналогично пропускать по реквизиту Ответственный.
Collaborator
|
смержил твой же соседний ПР #814 и опять конфликты все в том же tools/JSON/xUnitParams.json поправишь? |
…ументовКомментарийОтветственный
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Исправления по тесту Тесты_ПроверкаРеквизитовДокументовКомментарийОтветственный
сделанные изменения:
@vanessa-opensource/Collaborators - просьба прокомментировать и проверить